Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101722
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CALKiJKrnkH3MdHvuPpGbEjSx-y9JB8Q8rn5D9mcJFDQK8OGtmA@mail.gmail.com>
References: <CAEUnE0cRR6jtU2GoeiP4SDLJejF4+6zY=fT1FiTKPe6aKwoFqg@mail.gmail.com>
 <alpine.DEB.2.21.1801251441310.24989@singlemalt.home.derickrethans.nl>
 <9b12b0e2-185e-86fb-0e0b-c4f24bfbd661@gmail.com> <CAEUnE0fBE2eGbfimWw+AhPG+ZZ8WRNDLB+i1wE14NF_HARbQHQ@mail.gmail.com>
 <CANUQDChnG6fzFTr-RWixscg7pRy+dgqhwvUetRzjDxifmSiXHw@mail.gmail.com>
 <CAEUnE0dquLRkAf=ezF7Ufw9b2g6Hhgrs5FXN0_+N7z6drOEkJA@mail.gmail.com>
 <CANUQDChcXX98o1_AbKTTBjHMTdWBbh286CO1uK_mucBBZGZyTA@mail.gmail.com>
 <CAEUnE0eG8=iefTj8wQ+iBKrDr6smMhoogOZN2Ew=26gr3X7NhA@mail.gmail.com> <CALKiJKrnkH3MdHvuPpGbEjSx-y9JB8Q8rn5D9mcJFDQK8OGtmA@mail.gmail.com>
Date: Mon, 29 Jan 2018 13:14:43 -0600
Message-ID: <CAEUnE0coXB_iAQoRkwY_cBzDZotm3Wmy2QJAPvKR-BU8X2GJ4A@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c09421401fd150563ef0f02"
Subject: Re: [PHP-DEV][RFC][DISCUSSION] Collection Inspection
From: tendoaki@gmail.com (Michael Morris)

--94eb2c09421401fd150563ef0f02
Content-Type: text/plain; charset="UTF-8"

> The more angles we approach this, the more it looks like generics, or at
> least the same basis.


Which is well outside the scope of what I'd like to see, so let's look at
form 2 in closer detail - the all functions.

bool all_array( mixed $var ) {
  if (is_iterable($var) && !is_callable) {
    foreach ($var as $v) {
      if (!is_array($v)) return false;
    }
    return true;
  }
  return false;
}


That is the base function signature and implementation.  The is_callable()
above prevents iteration over generators, potentially consuming them for no
purpose.

The other functions in the family and their single value equivalents are:

is_bool -> all_bool
is_callable -> all_callable
is_double -> all_double
is_float -> all_float
is_int -> all_int
is_iterable -> all_iterable
is_long -> all_long
is_null -> all_null
is_numeric -> all_numeric
is_object -> all_object
is_real -> all_real
is_resource -> all_resource
is_scalar -> all_scalar
is_string -> all_string
is_subclass_of -> all_are

On the last one - is_subclass_of is generally more useful than is_a, but
will doing this cause confusion?  Also, not all of these need to be
included - the above is a list of candidate functions to create.  Of all of
these all_string() would probably see the most use followed by
all_numeric().

This will give the tools to do the desired assertions in a clean, easy to
read manner. Collections that must be of a single iterable class can also
be verified:

assert($a instanceof \SomeClass && all_string($a));

But most of the time $a will merely be an array.

--94eb2c09421401fd150563ef0f02--