Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101657
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.171 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <1516624483.18039.11.camel@schlueters.de>
References: <CAP=4hCK7Wb-m+RO7prV01n=+hNewQnJaNb6EBO_EHQ66NjoynA@mail.gmail.com>
 <1516624483.18039.11.camel@schlueters.de>
Date: Mon, 22 Jan 2018 10:15:59 -0700
Message-ID: <CAFMT4NrkTHYDNrB=4qwpgLTS7wYX1XoTM0c-ZHW-oWEGMUhTmQ@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: Gabriel Caruso <carusogabriel34@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] is_countable
From: levim@php.net (Levi Morrison)

On Mon, Jan 22, 2018 at 5:34 AM, Johannes Schl=C3=BCter
<johannes@schlueters.de> wrote:
> Hi,
>
> On So, 2018-01-21 at 18:01 +0000, Gabriel Caruso wrote:
>> After that, I like to propose and discuss a new function for PHP 7.x
>> (current 7.3): is_countable.
>>
>> *RFC*: https://wiki.php.net/rfc/is-countable.
>
> The primary place for this imo should be reflection.

You did not provide any justification. As you do so keep in mind a lot
of code is going to look like:

    if (is_countable($arg)) {
        /* take a different code path, such as pre-allocating storage */
    }

This is not an easily reflectable thing because it's based on an
argument which may not even be an object type. Additionally we have a
well-established convention of `is_*` function for types specifically
known to the engine as is the case here.