Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101653
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ca.ibm.com designates 148.163.158.5 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAESVnVrwWB8+nOd74Sh=8Rq7jtomna6_YPxhLc4Vs5BBM3Wpng@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>, php@golemon.com
Date: Mon, 22 Jan 2018 09:40:49 -0500
References: <OF84C52D9F.127868A7-ON0025821A.007326EA-8525821A.0073B9E3@notes.na.collabserv.com>
 <CAESVnVrwWB8+nOd74Sh=8Rq7jtomna6_YPxhLc4Vs5BBM3Wpng@mail.gmail.com>
Content-type: multipart/alternative; 
	Boundary="0__=8FBB088EDFC3BE758f9e8a93df938690918c8FBB088EDFC3BE75"
Content-Disposition: inline
Message-ID: <OFD3FCAE71.26BFD7B9-ON0025821D.005038E5-8525821D.0050A42B@notes.na.collabserv.com>
Subject: Re: [PHP-DEV] Big_Endian problem
From: samding@ca.ibm.com ("Sam Ding")

--0__=8FBB088EDFC3BE758f9e8a93df938690918c8FBB088EDFC3BE75
Content-Transfer-Encoding: quoted-printable
Content-type: text/plain; charset=US-ASCII

Thank Sara.

Yes,  on s390x, it is broken.
The function "ignore=5Fuser=5Fabort" returns "256" on s390x, and "1" on x86=
=5F64
after "ignore=5Fuser=5Fabort" is set to true;

Please let me know when you finished code changes on v7.2.1. I will test on
s390x.

Thanks,

Sam


php@golemon.com wrote on 01/19/2018 05:07:25 PM:

> From: Sara Golemon <pollita@php.net>
> To: Sam Ding <samding@ca.ibm.com>
> Cc: PHP internals <internals@lists.php.net>
> Date: 01/19/2018 05:07 PM
> Subject: Re: [PHP-DEV] Big=5FEndian problem
> Sent by: php@golemon.com
>
> On Fri, Jan 19, 2018 at 4:04 PM, Sam Ding <samding@ca.ibm.com> wrote:
> > The test case ext/standard/tests/general=5Ffunctions/bug72300.phpt is
failed
> > on s390x.
> > The function "ignore=5Fuser=5Fabort" returns "256" on s390x, and "1" on
x86=5F64
> > after "ignore=5Fuser=5Fabort" is set to true;
> > The root reason is because of Big=5FEndian on s390x.
> > Here is the C code:     ext/standard/basic=5Ffunctions.c
> > b/ext/standard/basic=5Ffunctions.c:5641
> >
> >    old=5Fsetting =3D (unsigned short)PG(ignore=5Fuser=5Fabort);
> >              //    php=5Fcore=5Fglobals.ignore=5Fuser=5Fabort, "x /2b" =
shows
its
> > value : "0x01 0x00" on both platforms
> >
> That specific line isn't the problem, as it's just cashing a short to
> an unsigned short, which is legal and not problematic for any
> endianness.
>
> The actual problem is that PG(ignore=5Fuser=5Fabort) is declared as a
> short, but its INI handler method is defined as OnUpdateBool (which of
> course, only operates on a single byte).
>
> >  Does PHP interpreter support Big=5FEndian? Are there any existing
> > macros/functions to deal with Big/Little Endian?
> >
> Yep.  And if things break on s390x, please let us know!
>
> I'll put together a fix for this over the weekend and apply it to 7.0
> and later versions.
>
> -Sara
>

--0__=8FBB088EDFC3BE758f9e8a93df938690918c8FBB088EDFC3BE75--