Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101632
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.216.174 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <OF84C52D9F.127868A7-ON0025821A.007326EA-8525821A.0073B9E3@notes.na.collabserv.com>
References: <OF84C52D9F.127868A7-ON0025821A.007326EA-8525821A.0073B9E3@notes.na.collabserv.com>
Date: Fri, 19 Jan 2018 17:07:25 -0500
Message-ID: <CAESVnVrwWB8+nOd74Sh=8Rq7jtomna6_YPxhLc4Vs5BBM3Wpng@mail.gmail.com>
To: Sam Ding <samding@ca.ibm.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Big_Endian problem
From: pollita@php.net (Sara Golemon)

On Fri, Jan 19, 2018 at 4:04 PM, Sam Ding <samding@ca.ibm.com> wrote:
> The test case ext/standard/tests/general_functions/bug72300.phpt is failed
> on s390x.
> The function "ignore_user_abort" returns "256" on s390x, and "1" on x86_64
> after "ignore_user_abort" is set to true;
> The root reason is because of Big_Endian on s390x.
> Here is the C code:     ext/standard/basic_functions.c
> b/ext/standard/basic_functions.c:5641
>
>    old_setting = (unsigned short)PG(ignore_user_abort);
>              //    php_core_globals.ignore_user_abort, "x /2b" shows its
> value : "0x01 0x00" on both platforms
>
That specific line isn't the problem, as it's just cashing a short to
an unsigned short, which is legal and not problematic for any
endianness.

The actual problem is that PG(ignore_user_abort) is declared as a
short, but its INI handler method is defined as OnUpdateBool (which of
course, only operates on a single byte).

>  Does PHP interpreter support Big_Endian? Are there any existing
> macros/functions to deal with Big/Little Endian?
>
Yep.  And if things break on s390x, please let us know!

I'll put together a fix for this over the weekend and apply it to 7.0
and later versions.

-Sara