Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101545
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.170 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <q0eu4d5lr38rsp2dmokb79d4bp2e8ip9t9@4ax.com>
References: <CAESVnVpyisK64S1d-nD76T=k2jaSi11wwCAE51uXmoe6c87wDw@mail.gmail.com>
 <e2du4d5kni5ksc8jt56jrbc8krgd7jaka0@4ax.com> <q0eu4d5lr38rsp2dmokb79d4bp2e8ip9t9@4ax.com>
Date: Fri, 5 Jan 2018 08:38:57 -0500
Message-ID: <CAESVnVqZGEX_L3nO-TcTcAs1PixnOAf49NNAJG15SsHFLLFJ=w@mail.gmail.com>
To: Jan Ehrhardt <phpdev@ehrhardt.nl>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: PHP 7.1.13 and 7.2.1 Available
From: pollita@php.net (Sara Golemon)

On Fri, Jan 5, 2018 at 3:50 AM, Jan Ehrhardt <phpdev@ehrhardt.nl> wrote:
>>Is it on purpose that the release-zip on github contains PHP 7.2.1-dev?
>>See the main/php_version.h in the zip at
>>https://github.com/php/php-src/releases
>
No, that was an accident.  Most of my process is automated, but that
got derailed slightly with the need to fill in for 7.1 and I goofed
up.  Also this was my first non-alpha/beta/RC release, so I got
semi-whelmed by that too. (Not overwhelmed, just whelmed). Sorry. :(
Unfortunately, it's too late to move the tag to the right commit
(which does exist!).  FWIW, the official (non-github) tarballs are
correct.

> The main reason why I prefer the github zips over the zips at
> http://windows.php.net/download/ is some kind of mismatch in the UTF-8
> filenames:
>
Whaaaa? That's broken and we should try to fix it.  I'll say that the
latest php-7.2.1 tarballs unpack fine for me. (e.g.
ext/bz2/tests/003=E7=A7=81=E3=81=AF=E3=82=AC=E3=83=A9=E3=82=B9=E3=82=92=E9=
=A3=9F=E3=81=B9=E3=82=89=E3=82=8C=E3=81=BE=E3=81=99.txt.bz2) maybe you're m=
issing a locale?

> The "central" filename version is the correct one, like the filename at
> https://github.com/php/php-src/tree/master/ext/bz2/tests
>
Okay, so you end up with the correct file on your filesystem, it's
just a warning during untarring?

> The zips at github do not have the mismatch and do contain the correct
> filenames. So github seems to handle UTF-8 filenames in better way than
> https://github.com/php/php-src/commit/3d3f11ede4cc7c83d64cc5edaae7c29ce9c=
6986f
>
Right. So it's likely the tar producer doing something weird.
php-src/makedist is doing a sort of git-archive, untar, add files,
retar dance (to ensure a clean state), whereas I assume github is just
doing a straight git-archive.

For the sake of reproducibility, what's your `tar --version`?
My build container is using GNU tar 1.27.1, and git 2.1.4

-Sara