Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101398
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c-kT3PVV8Ru_-UtLqWUmkKA-1HYK7GkFVQ+7RdJrv6efg@mail.gmail.com>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
 <CAF+90c-kT3PVV8Ru_-UtLqWUmkKA-1HYK7GkFVQ+7RdJrv6efg@mail.gmail.com>
Date: Tue, 19 Dec 2017 17:09:55 -0500
Message-ID: <CAEUnE0c8zuabOaa27fBYwug1C_LvoK7w9ajP_yWL1EsW0DhbRA@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c030b641c222d0560b8bad7"
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes
 on non-object constants.
From: tendoaki@gmail.com (Michael Morris)

--94eb2c030b641c222d0560b8bad7
Content-Type: text/plain; charset="UTF-8"

What would it hurt to allow instanceof to return types other than object?

$x instanceof NULL
$x instanceof string

and so on.  This would be more powerful and useful than throwing an error
where one wasn't being thrown before. It also would let one operator detect
all the types, rather than the plethora of detect functions we currently
have.

On Tue, Dec 19, 2017 at 4:48 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Sat, Dec 9, 2017 at 7:28 AM, Andreas Hennings <andreas@dqxtech.net>
> wrote:
>
> > The following (https://3v4l.org/A2Tp6) is ok, it simply returns false:
> >
> >     $x = 1;
> >     $x instanceof \stdClass;
> >
> >
> > The following (https://3v4l.org/IdSBu) gives a fatal error:
> >
> >     1 instanceof \stdclass;
> >
> > t think this behavior is inconsistent, and we should consider changing
> it.
> >
> > There are two options, but only one is BC.
> >
> > - Let 1 instanceof \stdClass return false, instead of crashing. -> seems
> BC
> > - Let $x instanceof \stdClass crash, if $x is not an object. -> BC break.
> >
> > So it seems the first would the option we should take.
> > This is also what hhvm does, according to https://3v4l.org/IdSBu.
> >
>
> I've prepared a PR for this change: https://github.com/php/php-
> src/pull/2978
>
> From the discussion I'm understanding that our consensus is to implement
> this change, so if there are no further objection I'll merge this in a few
> days.
>
> Nikita
>

--94eb2c030b641c222d0560b8bad7--