Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101397
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
Date: Tue, 19 Dec 2017 22:48:10 +0100
Message-ID: <CAF+90c-kT3PVV8Ru_-UtLqWUmkKA-1HYK7GkFVQ+7RdJrv6efg@mail.gmail.com>
To: Andreas Hennings <andreas@dqxtech.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a113f729254f8980560b86ca3"
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes
 on non-object constants.
From: nikita.ppv@gmail.com (Nikita Popov)

--001a113f729254f8980560b86ca3
Content-Type: text/plain; charset="UTF-8"

On Sat, Dec 9, 2017 at 7:28 AM, Andreas Hennings <andreas@dqxtech.net>
wrote:

> The following (https://3v4l.org/A2Tp6) is ok, it simply returns false:
>
>     $x = 1;
>     $x instanceof \stdClass;
>
>
> The following (https://3v4l.org/IdSBu) gives a fatal error:
>
>     1 instanceof \stdclass;
>
> t think this behavior is inconsistent, and we should consider changing it.
>
> There are two options, but only one is BC.
>
> - Let 1 instanceof \stdClass return false, instead of crashing. -> seems BC
> - Let $x instanceof \stdClass crash, if $x is not an object. -> BC break.
>
> So it seems the first would the option we should take.
> This is also what hhvm does, according to https://3v4l.org/IdSBu.
>

I've prepared a PR for this change: https://github.com/php/php-src/pull/2978

From the discussion I'm understanding that our consensus is to implement
this change, so if there are no further objection I'll merge this in a few
days.

Nikita

--001a113f729254f8980560b86ca3--