Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101395
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.176 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <AM3PR02MB1010437D4705BB201DD05464BA0F0@AM3PR02MB1010.eurprd02.prod.outlook.com>
References: <CAESVnVobB2pjLiwR0D85q++Ymau69qO8bH2GcH+XF8B7cb5tWw@mail.gmail.com>
 <AM3PR02MB1010437D4705BB201DD05464BA0F0@AM3PR02MB1010.eurprd02.prod.outlook.com>
Date: Tue, 19 Dec 2017 16:05:10 -0500
Message-ID: <CAESVnVrBG+qgWpfMTqPnKN2sW+9nygkKizjL4o4ezco0cBtq-A@mail.gmail.com>
To: Anatol Belski <ab@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] C++ and FAST_ZPP macros
From: pollita@php.net (Sara Golemon)

On Tue, Dec 19, 2017 at 3:29 PM, Anatol Belski <ab@php.net> wrote:
>> As the blog post notes, it's a simple matter to work around the bug in extension
>> code (indeed, an extension can simply opt to not use FAST_ZPP).  On the other
>> hand, the fix is pretty basic, and existing functionality of the default expected
>> type effectively being Z_EXPECTED_LONG (because both have a value of zero) is
>> just a bit....
>> weird.
>>
>> Thoughts?  If I don't hear anything in a week, I'll just apply to 7.1 and merge up.
>>
> C++11 requires a validity scope for enums, thus this change is unavoidable.
> IMO your second suggestion were safer in the spirit of BC - Z_EXPECTED_LONG
> instead of IS_UNDEF by default, and a new in master. Just because a workaround
> is possible and otherwise the issue is not critical.
>
Yeah, the more I think about it, the more I realize that's the more
prudent approach given the non-critical nature of this.  Could you
clarify as 7.0 RM if you want this on your branch? AIUI we're in
security-only for 7.0 now, yes?

-Sara