Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:101364 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74030 invoked from network); 18 Dec 2017 19:43:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Dec 2017 19:43:46 -0000 Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.178 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.220.178 mail-qk0-f178.google.com Received: from [209.85.220.178] ([209.85.220.178:35367] helo=mail-qk0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C6/E7-21958-E6A183A5 for ; Mon, 18 Dec 2017 14:43:44 -0500 Received: by mail-qk0-f178.google.com with SMTP id 143so5073378qki.2 for ; Mon, 18 Dec 2017 11:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:from:date:message-id:subject:to; bh=BjAgLTbG355HV5gtsujarS2HWYPpuBH6coZre+GH8LM=; b=n8AobPoDu4PfsfFVoH/jOPl1LjV5Fhkoe05HO9j4iYid44cPTHZVkhw+EWOsSQzU4i Auu7vbD2YXlpnSmA7jMUIs5a66d0LyYhQpn87MqBUKilvC01Kd8CKDzvCc0oP54JbCod gMh4DNkveRxnlSACEZy4ncP5p/qsYnWrvx+wz7ZGe+tQ4d+CSxbM7P55m1QBARWfH61T iMKcBj5mjs6bqNxwY66a1/BzLGfB3t7I+MRj6ii7L3nqIvwYi2lMyoYN9Nn8HSqR/Mxf 70awDgmZeOTNd8oOVZ1lGxJ10Kbx21ruf+CeiOruWv08SOT3tvcOSFU+YjxuMFA5yfd6 WhNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=BjAgLTbG355HV5gtsujarS2HWYPpuBH6coZre+GH8LM=; b=qHyqVLxEPj2KNdO2IinBZZ7Ei/DEnCUpnvNjGIk4o00RzhG3dPneCeujba+jGlWhRH eV4LT9kAZ8iP9CHsaGnw1rrpqkcVAc1ZpqJGPRph0xUU3R85j8KyphD9t1IyE4ZChiDb YtK9qhJh1/ZY3jonJh4phdIJUaBZcZ1MWaMMyA+y5zljSNnV0GhX9Ax7xdDZ1VVb4jEx Ae1kGyCNNkWz9q9oDAWnz6y1DvTKwdWP8KOdV4GJqdJH7iSoyZuWcnKseyU8lG9VKlkB D6t94hXmUz6OmTN3cjo78R94tr4SVF7NV7fftyaE2iPagx3QH0kabAlQSZM726SMkyL4 Zpqg== X-Gm-Message-State: AKGB3mKnPruT6Ibe4TzHtgkvaMtlpuU8RN6RNUwccAkVwecxkvIz92Eb KShYx0PY1giG70pwPfer5maal1kRLXWk11X785mlyEQ4 X-Google-Smtp-Source: ACJfBotYBFXcTzF/fhbX4EtrdBnA+CN+GW2rIejXWfPRIzq1r4Aq1hXp+K+FQbO1Sd+W91kq/0vyDuth+svHqgAD61Y= X-Received: by 10.55.18.134 with SMTP id 6mr1346745qks.136.1513626219571; Mon, 18 Dec 2017 11:43:39 -0800 (PST) MIME-Version: 1.0 Sender: php@golemon.com Received: by 10.12.158.145 with HTTP; Mon, 18 Dec 2017 11:43:38 -0800 (PST) X-Originating-IP: [206.252.215.26] Date: Mon, 18 Dec 2017 14:43:38 -0500 X-Google-Sender-Auth: 19uLaXWFtbgXQVnqCoZGqYdrln8 Message-ID: To: PHP internals Content-Type: text/plain; charset="UTF-8" Subject: C++ and FAST_ZPP macros From: pollita@php.net (Sara Golemon) This blog post came across my twitter today and it's certainly legit. https://cismon.net/2017/12/18/Fast-ZPP-s-Incompatibility-with-CPP/ I tossed together this quick and dirty fix (and tested it with a simple C++ extension), but I wanted to get a read on what branch folks think it should be applied to. https://github.com/sgolemon/php-src/commit/469ddd26331dbd736ad13eaac7170ccc43d09c7f As the blog post notes, it's a simple matter to work around the bug in extension code (indeed, an extension can simply opt to not use FAST_ZPP). On the other hand, the fix is pretty basic, and existing functionality of the default expected type effectively being Z_EXPECTED_LONG (because both have a value of zero) is just a bit.... weird. Thoughts? If I don't hear anything in a week, I'll just apply to 7.1 and merge up. -Sara