Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:10136
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <20040528061941.18048.qmail@pb1.pair.com>
To: internals@lists.php.net
Date: Fri, 28 May 2004 08:19:47 +0200
User-Agent: Mozilla Thunderbird 0.6 (Windows/20040502)
MIME-Version: 1.0
References: <20040527155047.GA36904@gravitonic.com> <20040527184929.GB23166@csh.rit.edu> <20040527190601.45769.qmail@pb1.pair.com> <20040527200440.GA38203@gravitonic.com> <20040527213949.29052.qmail@pb1.pair.com> <20040527225223.GA38890@gravitonic.com> <20040527230203.72676.qmail@pb1.pair.com>
In-Reply-To: <20040527230203.72676.qmail@pb1.pair.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [patch] re-invoking default error handler
From: bert@procurios.nl (Bert Slagter)

Sara Golemon wrote:
>>>This just means replacing the first line of that patch with:
>>>      if (Z_TYPE_P(retval) != IS_NULL && !zend_is_true(retval)) {
>>
>>This would be fine with me. What do we all thing about feasibility of
>>this patch going into PHP 5?
>>
> 
> +0
> 
> No great harm in doing it, but for myself if I'm going to override the error
> handler, I'm going to override the entire error handler.
> 
> -Sara

You can't handle all errorlevels with a custom error handler, at the 
moment E_STRICT (why this one by the way?), E_ERROR, E_PARSE, 
E_CORE_ERROR, E_CORE_WARNING, E_COMPILE_ERROR and E_COMPILE_WARNING 
cannot be handled. So I can understand that one decides to leave 
E_NOTICE and E_WARNING to PHP as well and only handles E_USER_* himself.

I see a situation where it might be useful, but I won't use it myself.

And a point to be taken in consideration: it might obscure the error 
handling process a bit. Right now it isn't very easy to understand (I 
see new colleagues have a hard time trying to understand this monthly) :).

Bert