Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101315
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain dqxtech.net from 209.85.215.51 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAH0Uv3ENcq2f+q=cJ4aqTzehEsWaXJZ-JzL2gNYNdV4rQ8xqtA@mail.gmail.com>
References: <CAH0Uv3ErvVo5qPotvrHby7AKrzUQix_YuDU5dbQWos8bvCASqw@mail.gmail.com>
 <CANUQDChCkt0CzYHeJoRN+d7_wWBe82-J5MJEgXWFj9qTBMz4Zg@mail.gmail.com>
 <CAH0Uv3FNGUTtUKx8SA=VJ2MKUQmdt1Rd0vqQXCZt_zk3n6tqQA@mail.gmail.com>
 <CADyq6sJ4SBPTbnwQo+5Qzna_jM8chuurqDGFK8ucNW63VdUQ_g@mail.gmail.com>
 <CAH0Uv3Ebvg+Jpgn9hkNw+ScatjKvKz3wRGpM7SbHVkX+KGS1nA@mail.gmail.com>
 <CADyq6sKjNYu2PN1PheFeZ=Jv4Q_1Vkcc4wH9yV4+iYoTYpPLLQ@mail.gmail.com> <CAH0Uv3ENcq2f+q=cJ4aqTzehEsWaXJZ-JzL2gNYNdV4rQ8xqtA@mail.gmail.com>
Date: Mon, 11 Dec 2017 09:28:06 +0100
Message-ID: <CAH0Uv3ECCGzyK06gaWPk1KFyD-kwJ0W1rspO0T2r5aSmGgh=wg@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Niklas Keller <me@kelunik.com>, PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] ReflectionContext for imports and namespace
From: andreas@dqxtech.net (Andreas Hennings)

On 11 December 2017 at 09:23, Andreas Hennings <andreas@dqxtech.net> wrote:
>>> These side effects would be that the class loader loads files which can
>>> break things?
>>
>>
>> Yes. Reflecting over a codebase which contains even just polyfills
>> (duplicate classes) can already lead to unexpected crashes. Reflecting over
>> non-PSR-2 code can even lead to worse things such as starting a DB
>> connection and performing unwanted operations.
>>
>
> My own use case avoids this problem.
> Instead of randomly scanning anything, you need to tell the annotation
> parser explicitly which namespace directory you want to scan.
> It is the caller's responsibility that all class files in this
> directory are nicely shaped, and can be safely autoloaded.
>
> In fact I did use a userland parser in the past, but then decided that
> native reflection is safe with the above assumption.


Maybe one fragile edge case would be if one of the files causes the
autoloader to include a different file, outside of the library, due to
ambiguous namespace mapping.
But this problem would also occur during everyday use of the library,
if this class is used.

So the condition is: Only scan namespace directories where you know
that every class can be safely autoloaded.
In fact I do not explicitly include the class file, but let the class
loader do this, to be sure that the same version of the class is used
that would be used in a regular request / process.