Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101314
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain dqxtech.net from 209.85.215.50 cause and error)
MIME-Version: 1.0
In-Reply-To: <CADyq6sKjNYu2PN1PheFeZ=Jv4Q_1Vkcc4wH9yV4+iYoTYpPLLQ@mail.gmail.com>
References: <CAH0Uv3ErvVo5qPotvrHby7AKrzUQix_YuDU5dbQWos8bvCASqw@mail.gmail.com>
 <CANUQDChCkt0CzYHeJoRN+d7_wWBe82-J5MJEgXWFj9qTBMz4Zg@mail.gmail.com>
 <CAH0Uv3FNGUTtUKx8SA=VJ2MKUQmdt1Rd0vqQXCZt_zk3n6tqQA@mail.gmail.com>
 <CADyq6sJ4SBPTbnwQo+5Qzna_jM8chuurqDGFK8ucNW63VdUQ_g@mail.gmail.com>
 <CAH0Uv3Ebvg+Jpgn9hkNw+ScatjKvKz3wRGpM7SbHVkX+KGS1nA@mail.gmail.com> <CADyq6sKjNYu2PN1PheFeZ=Jv4Q_1Vkcc4wH9yV4+iYoTYpPLLQ@mail.gmail.com>
Date: Mon, 11 Dec 2017 09:23:38 +0100
Message-ID: <CAH0Uv3ENcq2f+q=cJ4aqTzehEsWaXJZ-JzL2gNYNdV4rQ8xqtA@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Niklas Keller <me@kelunik.com>, PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] ReflectionContext for imports and namespace
From: andreas@dqxtech.net (Andreas Hennings)

>> These side effects would be that the class loader loads files which can
>> break things?
>
>
> Yes. Reflecting over a codebase which contains even just polyfills
> (duplicate classes) can already lead to unexpected crashes. Reflecting over
> non-PSR-2 code can even lead to worse things such as starting a DB
> connection and performing unwanted operations.
>

My own use case avoids this problem.
Instead of randomly scanning anything, you need to tell the annotation
parser explicitly which namespace directory you want to scan.
It is the caller's responsibility that all class files in this
directory are nicely shaped, and can be safely autoloaded.

In fact I did use a userland parser in the past, but then decided that
native reflection is safe with the above assumption.