Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101291
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.177 as permitted sender)
Date: Sun, 10 Dec 2017 12:45:39 +0000
User-Agent: K-9 Mail for Android
In-Reply-To: <CANUQDChcXKEU0WtbD6jBVCcBiAMqAS6TAU5B=7PV5SU90rxKfg@mail.gmail.com>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com> <CAESVnVpWo=T0K6Vn-1Kmu-LjbC98DTvJhHru7chx8kWjsXw7QA@mail.gmail.com> <CANUQDChcXKEU0WtbD6jBVCcBiAMqAS6TAU5B=7PV5SU90rxKfg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
To: internals@lists.php.net
Message-ID: <560EA30C-02FD-4389-B9D3-F577C1DF6B41@gmail.com>
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes on non-object constants.
From: rowan.collins@gmail.com (Rowan Collins)

On 10 December 2017 11:05:23 GMT+00:00, Niklas Keller <me@kelunik=2Ecom> wr=
ote:
>>
>> This=2E  There's nothing undefinable about "1 instanceof \stdClass",
>the
>> clear and obvious answer is: "No, it's not an instance of \stdClass,
>> it's an integer=2E"  The runtime result of false makes sense, the
>> compile time error doesn't=2E  Let's relax the compile time error (fold
>> it into a const false if you truly must) and call it done=2E  There's
>no
>> need to be hostile to users just because the code *seems* silly=2E
>>
>
>This code doesn't just *seem* silly=2E For everything but testing whether
>it
>works it is totally useless=2E

It's useless, but also harmless=2E Unless anyone can think of a scenario w=
here someone would do this by mistake intending to do something else?


>But we might turn the fatal error into a warning like we do it for
>"use" in
>the global namespace: https://3v4l=2Eorg/ph7KW

I feel like both that example and the case we're discussing should be a no=
tice at most; it's not telling me my code is broken, just that some of it's=
 unnecessary=2E Maybe I've decided it makes my code more self-documenting, =
and don't care that the compiler thinks I'm dumb=2E

Adding warnings has a "boy who cried wolf" cost: if people get used to ign=
oring ones they disagree with, they'll miss ones that are genuine problems=
=2E=20

Regards,

--=20
Rowan Collins
[IMSoP]