Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101289
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.161 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAESVnVpWo=T0K6Vn-1Kmu-LjbC98DTvJhHru7chx8kWjsXw7QA@mail.gmail.com>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
 <CAESVnVpWo=T0K6Vn-1Kmu-LjbC98DTvJhHru7chx8kWjsXw7QA@mail.gmail.com>
Date: Sun, 10 Dec 2017 12:05:23 +0100
Message-ID: <CANUQDChcXKEU0WtbD6jBVCcBiAMqAS6TAU5B=7PV5SU90rxKfg@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Andreas Hennings <andreas@dqxtech.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a1140cbeafac4c7055ffa641f"
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes
 on non-object constants.
From: me@kelunik.com (Niklas Keller)

--001a1140cbeafac4c7055ffa641f
Content-Type: text/plain; charset="UTF-8"

>
> This.  There's nothing undefinable about "1 instanceof \stdClass", the
> clear and obvious answer is: "No, it's not an instance of \stdClass,
> it's an integer."  The runtime result of false makes sense, the
> compile time error doesn't.  Let's relax the compile time error (fold
> it into a const false if you truly must) and call it done.  There's no
> need to be hostile to users just because the code *seems* silly.
>

This code doesn't just *seem* silly. For everything but testing whether it
works it is totally useless.

But we might turn the fatal error into a warning like we do it for "use" in
the global namespace: https://3v4l.org/ph7KW

Regards, Niklas

--001a1140cbeafac4c7055ffa641f--