Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101287
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.179 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
Date: Sat, 9 Dec 2017 18:49:40 -0500
Message-ID: <CAESVnVpWo=T0K6Vn-1Kmu-LjbC98DTvJhHru7chx8kWjsXw7QA@mail.gmail.com>
To: Andreas Hennings <andreas@dqxtech.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes
 on non-object constants.
From: pollita@php.net (Sara Golemon)

On Sat, Dec 9, 2017 at 1:28 AM, Andreas Hennings <andreas@dqxtech.net> wrote:
> The following (https://3v4l.org/A2Tp6) is ok, it simply returns false:
>
>     $x = 1;
>     $x instanceof \stdClass;
>
>
> The following (https://3v4l.org/IdSBu) gives a fatal error:
>
>     1 instanceof \stdclass;
>
> t think this behavior is inconsistent, and we should consider changing it.
>
> There is one option, and it is BC.
>
> - Let 1 instanceof \stdClass return false, instead of crashing. -> seems BC
>
This.  There's nothing undefinable about "1 instanceof \stdClass", the
clear and obvious answer is: "No, it's not an instance of \stdClass,
it's an integer."  The runtime result of false makes sense, the
compile time error doesn't.  Let's relax the compile time error (fold
it into a const false if you truly must) and call it done.  There's no
need to be hostile to users just because the code *seems* silly.

-Sara