Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101285
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.42 as permitted sender)
To: Andreas Hennings <andreas@dqxtech.net>,
 PHP internals <internals@lists.php.net>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
Message-ID: <50e2ef67-7f9e-3910-988d-684cf9c57be3@gmail.com>
Date: Sat, 9 Dec 2017 15:09:28 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes
 on non-object constants.
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> t think this behavior is inconsistent, and we should consider changing it.
> 
> There are two options, but only one is BC.
> 
> - Let 1 instanceof \stdClass return false, instead of crashing. -> seems BC
> - Let $x instanceof \stdClass crash, if $x is not an object. -> BC break.

Neither of those "crashes", one of them returns fatal error, which is a
valid option for code that is obviously broken. It would also be a valid
option to return false, but since it is a valid outcome either way, I
don't think changing anything is necessary. It does not make any real
code easier to write (I can't see any legit reason to test numerics for
being instance of anything) and does not improve anything but abstract
"consistency", which in this case is not useful for anything.

-- 
Stas Malyshev
smalyshev@gmail.com