Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101283
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.179 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CAJW__o0Cf1b6pw_eAUb1MFJYi-akyarGNbdbkob+0fP-Pn2wxg@mail.gmail.com>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
 <CAJW__o0Cf1b6pw_eAUb1MFJYi-akyarGNbdbkob+0fP-Pn2wxg@mail.gmail.com>
Date: Sat, 9 Dec 2017 12:05:41 -0700
Message-ID: <CAFMT4NrynLLK_7tfAaMiWo6j_tLb_HYefZGtWJdF9ARtduRU=Q@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Andreas Hennings <andreas@dqxtech.net>, Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes
 on non-object constants.
From: levim@php.net (Levi Morrison)

On Fri, Dec 8, 2017 at 11:35 PM, Kalle Sommer Nielsen <kalle@php.net> wrote:
> We should just add a warning to the first example, it seems like an
> oversight that it was left silent

I strongly object! We ought to consider using `instanceof` to support
more type-checks than just classes. I think `1 instanceof int` really
ought to return true for both literals and if they were variables:

    $lhs = 1;
    $rhs = 'int';
    var_export($lhs instanceof $rhs);

The fact we do not have a single, unified way to check if some value
on the LHS is of the type on the RHS really bothers me.