Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101275
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain dqxtech.net from 209.85.215.52 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAJW__o0Cf1b6pw_eAUb1MFJYi-akyarGNbdbkob+0fP-Pn2wxg@mail.gmail.com>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
 <CAJW__o0Cf1b6pw_eAUb1MFJYi-akyarGNbdbkob+0fP-Pn2wxg@mail.gmail.com>
Date: Sat, 9 Dec 2017 07:38:14 +0100
Message-ID: <CAH0Uv3GTxUDNg5W1vUcynsbNfA=k-rnYDXdF3mYKZB2P_+wmLQ@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a1140754ceb8020055fe28c08"
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes
 on non-object constants.
From: andreas@dqxtech.net (Andreas Hennings)

--001a1140754ceb8020055fe28c08
Content-Type: text/plain; charset="UTF-8"

Adding a warning to something that used to be ok would break existing code.
I remember a number of cases where I used instanceof on possibly
non-objects.

if ($x instanceof C) {
  return $x;
}
elseif ($x === NULL) {
 ...
}

All such code would then produce warnings.


On 9 December 2017 at 07:35, Kalle Sommer Nielsen <kalle@php.net> wrote:

> Hi
>
> We should just add a warning to the first example, it seems like an
> oversight that it was left silent
>
> On 9 Dec 2017 07.29, "Andreas Hennings" <andreas@dqxtech.net> wrote:
>
>> The following (https://3v4l.org/A2Tp6) is ok, it simply returns false:
>>
>>     $x = 1;
>>     $x instanceof \stdClass;
>>
>>
>> The following (https://3v4l.org/IdSBu) gives a fatal error:
>>
>>     1 instanceof \stdclass;
>>
>> t think this behavior is inconsistent, and we should consider changing it.
>>
>> There are two options, but only one is BC.
>>
>> - Let 1 instanceof \stdClass return false, instead of crashing. -> seems
>> BC
>> - Let $x instanceof \stdClass crash, if $x is not an object. -> BC break.
>>
>> So it seems the first would the option we should take.
>> This is also what hhvm does, according to https://3v4l.org/IdSBu.
>>
>

--001a1140754ceb8020055fe28c08--