Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101274
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.177 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
References: <CAH0Uv3EU9pHu+NA5OPsycKWy2WQ41WK5vivTE8Z-oNP5_G=0cg@mail.gmail.com>
Date: Sat, 9 Dec 2017 07:35:30 +0100
Message-ID: <CAJW__o0Cf1b6pw_eAUb1MFJYi-akyarGNbdbkob+0fP-Pn2wxg@mail.gmail.com>
To: Andreas Hennings <andreas@dqxtech.net>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a1141ac2efc4fae055fe281dc"
Subject: Re: [PHP-DEV] instanceof survives non-object variables, but crashes
 on non-object constants.
From: kalle@php.net (Kalle Sommer Nielsen)

--001a1141ac2efc4fae055fe281dc
Content-Type: text/plain; charset="UTF-8"

Hi

We should just add a warning to the first example, it seems like an
oversight that it was left silent

On 9 Dec 2017 07.29, "Andreas Hennings" <andreas@dqxtech.net> wrote:

> The following (https://3v4l.org/A2Tp6) is ok, it simply returns false:
>
>     $x = 1;
>     $x instanceof \stdClass;
>
>
> The following (https://3v4l.org/IdSBu) gives a fatal error:
>
>     1 instanceof \stdclass;
>
> t think this behavior is inconsistent, and we should consider changing it.
>
> There are two options, but only one is BC.
>
> - Let 1 instanceof \stdClass return false, instead of crashing. -> seems BC
> - Let $x instanceof \stdClass crash, if $x is not an object. -> BC break.
>
> So it seems the first would the option we should take.
> This is also what hhvm does, according to https://3v4l.org/IdSBu.
>

--001a1141ac2efc4fae055fe281dc--