Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:10126 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57025 invoked by uid 1010); 27 May 2004 23:31:33 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 57000 invoked from network); 27 May 2004 23:31:32 -0000 Received: from unknown (HELO colo.lerdorf.com) (66.198.51.121) by pb1.pair.com with SMTP; 27 May 2004 23:31:32 -0000 Received: from rasmus2.corp.yahoo.com (rasmus2.corp.yahoo.com [207.126.233.18]) by colo.lerdorf.com (8.12.11/8.12.11/Debian-5) with ESMTP id i4RNVV8w001777; Thu, 27 May 2004 16:31:31 -0700 Date: Thu, 27 May 2004 16:31:26 -0700 (PDT) X-X-Sender: rasmus@thinkpad.lerdorf.com To: Sara Golemon cc: internals@lists.php.net In-Reply-To: <20040527230203.72676.qmail@pb1.pair.com> Message-ID: References: <20040527155047.GA36904@gravitonic.com> <20040527184929.GB23166@csh.rit.edu> <20040527190601.45769.qmail@pb1.pair.com> <20040527200440.GA38203@gravitonic.com> <20040527213949.29052.qmail@pb1.pair.com> <20040527225223.GA38890@gravitonic.com> <20040527230203.72676.qmail@pb1.pair.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on colo Subject: Re: [PHP-DEV] [patch] re-invoking default error handler From: rasmus@php.net (Rasmus Lerdorf) On Thu, 27 May 2004, Sara Golemon wrote: > > > This just means replacing the first line of that patch with: > > > if (Z_TYPE_P(retval) != IS_NULL && !zend_is_true(retval)) { > > > > This would be fine with me. What do we all thing about feasibility of > > this patch going into PHP 5? > > > +0 > > No great harm in doing it, but for myself if I'm going to override the error > handler, I'm going to override the entire error handler. The need that came up here was that people only wanted to use their error handler for their own trigger_error()'ed errors. For normal PHP errors they still wanted to use the default handler. This request does make some sense, and hence Andrei's patch. -Rasmus