Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:10125 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72701 invoked by uid 1010); 27 May 2004 23:02:03 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 72677 invoked by uid 1007); 27 May 2004 23:02:03 -0000 Message-ID: <20040527230203.72676.qmail@pb1.pair.com> To: internals@lists.php.net References: <20040527155047.GA36904@gravitonic.com> <20040527184929.GB23166@csh.rit.edu> <20040527190601.45769.qmail@pb1.pair.com> <20040527200440.GA38203@gravitonic.com> <20040527213949.29052.qmail@pb1.pair.com> <20040527225223.GA38890@gravitonic.com> Date: Thu, 27 May 2004 16:02:02 -0700 Lines: 14 X-Priority: 3 X-MSMail-Priority: Normal X-Newsreader: Microsoft Outlook Express 6.00.2800.1409 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-Posted-By: 169.229.135.175 Subject: Re: [PHP-DEV] [patch] re-invoking default error handler From: pollita@php.net ("Sara Golemon") > > This just means replacing the first line of that patch with: > > if (Z_TYPE_P(retval) != IS_NULL && !zend_is_true(retval)) { > > This would be fine with me. What do we all thing about feasibility of > this patch going into PHP 5? > +0 No great harm in doing it, but for myself if I'm going to override the error handler, I'm going to override the entire error handler. -Sara