Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:10119
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <20040527190601.45769.qmail@pb1.pair.com>
To: internals@lists.php.net
Date: Thu, 27 May 2004 22:06:01 +0300
References: <20040527155047.GA36904@gravitonic.com> <20040527184929.GB23166@csh.rit.edu>
Lines: 24
User-Agent: KNode/0.7.7
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7Bit
Subject: Re: [PHP-DEV] [patch] re-invoking default error handler
From: lenar@city.ee (Lenar =?ISO-8859-1?Q?L=F5hmus?=)

Jon Parise wrote:

> The convention(*) for these kinds of things is generally to return
> 'true' when you've handled the message/event and want to discontinue
> further processing.  Returning 'false' indicates that you haven't
> handled the event.

You are right. That's how it should be done.

>> It's backwards compatible with previous functionality, i.e. if you don't
>> return anything, the default handler does not get invoked.
> 
> This argument may overrule my preference, of course.

Since error_handler is called from inside PHP engine, there should be no
noticable BC problem. Only the case when developer calls his function
directly too and does so in if/while/etc might be problem. But I don't
think this is showstopper.

Anyway, neat feature, please add (after return value inversion).

Lenar