Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:101163 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 38725 invoked from network); 27 Nov 2017 16:38:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Nov 2017 16:38:53 -0000 Authentication-Results: pb1.pair.com header.from=ml@anderiasch.de; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ml@anderiasch.de; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain anderiasch.de designates 81.169.138.148 as permitted sender) X-PHP-List-Original-Sender: ml@anderiasch.de X-Host-Fingerprint: 81.169.138.148 ares.art-core.org Received: from [81.169.138.148] ([81.169.138.148:60088] helo=ares.art-core.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 29/A8-26862-B9F3C1A5 for ; Mon, 27 Nov 2017 11:38:52 -0500 Received: from [192.168.178.20] (p4FC4A9F3.dip0.t-ipconnect.de [79.196.169.243]) by ares.art-core.org (mail.art-core.org) with ESMTPSA id 148AB10380018; Mon, 27 Nov 2017 16:38:49 +0000 (UTC) To: Sara Golemon Cc: PHP internals , Dan Ackroyd References: <73a4b3a5-5a48-fdab-8d7a-08cc596661ff@anderiasch.de> <587c708c-48b9-b18e-098f-26ac0a113cc8@anderiasch.de> <142a4a73-ee43-efea-d1f9-69ad981178f9@anderiasch.de> Message-ID: Date: Mon, 27 Nov 2017 17:38:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] net_get_interfaces() From: ml@anderiasch.de (Florian Anderiasch) On 27.11.2017 16:38, Sara Golemon wrote: > On Mon, Nov 27, 2017 at 10:34 AM, Florian Anderiasch wrote: >> Also I'm really sorry that I disappointed you by not managing to finish >> testing on OpenBSD (which I actually started just before seeing this >> mail) and I already sent some results for FreeBSD yesterday, which >> showed a tiny issue. >> > Yes! I saw that! Thank you. It wasn't so much a BSD issue as the fact > you did a bare build, while my default build happens to include the > sockets extension (which provides the AF_INET constant I was using in > the unit test). Thanks to your testing, I was able to refactor the > test slightly to not require ext/sockets be enabled in order to work. > :D > > -Sara > No worries, nothing in that was directed at you, Sara. (But not sure if having to enable sockets proves my point or not, I guess it did provide at least some value). Good news: master after the merge works on OpenBSD, once the build is fixed. Somehow it doesn't match the +#if HAVE_NET_IF_H in net.c I had to unconditionally include it (for testing), otherwise IFF_BROADCAST and IFF_POINTOPOINT are undefined. (they are in sys/net/if.h on OpenBSD, but I only tested 6.2). Can do a proper bug report if needed, but maybe I get around to test NetBSD as well. Greetings, Florian