Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101155
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain anderiasch.de designates 81.169.138.148 as permitted sender)
To: PHP internals <internals@lists.php.net>
Cc: Sara Golemon <pollita@php.net>
References: <CAESVnVr39c8Dw+6D2t5YCjBLMECioC6tQHV51-W2nVsth6awnQ@mail.gmail.com>
 <73a4b3a5-5a48-fdab-8d7a-08cc596661ff@anderiasch.de>
 <CAESVnVoc2G1NykrDh2OasF3qtjFR+jgof=xca+4otbkXv2L=KQ@mail.gmail.com>
Message-ID: <587c708c-48b9-b18e-098f-26ac0a113cc8@anderiasch.de>
Date: Sun, 26 Nov 2017 17:28:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAESVnVoc2G1NykrDh2OasF3qtjFR+jgof=xca+4otbkXv2L=KQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] net_get_interfaces()
From: ml@anderiasch.de (Florian Anderiasch)

On 26.11.2017 17:10, Sara Golemon wrote:
> On Sun, Nov 26, 2017 at 10:53 AM, Florian Anderiasch <ml@anderiasch.de> wrote:
>> Looks good in theory, but without a lot of thought, how likely is this
>> to break/work on "supported" operating systems? (Which ones are that,
>> actually? http://php.net/manual/en/install.unix.php lists the BSDs and
>> Solaris and HP/UX)
>>
>> I know, it explicitly mentions Windows and Linux - also probably someone
>> tried it on OSX, and I don't think (Free|Open|Net)BSD will be a big
>> problem here, but as I'm no expert on that - does that matter? Will it
>> need "just a little work" or could the more exotic ones be more problematic?
>>
> Without a comprehensive CI matrix to run diffs like this against,
> there's no way to be absolutely certain it'll work everywhere.
> 
> That said, the config.m4 changes specifically test for the new APIs
> being used.  If they fail to compile in a standalone environment, the
> new function isn't enabled for compilation in the main build.  So, at
> worst, we may find some OSs (AIX, Solaris, etc...) simply don't gain
> the new functionality, but it shouldn't {knock on wood} cause any
> builds to break.  If it does, we have an entire year for interested
> parties to catch it.

Yeah, I know, and I'd agree on the "absolutely certain" part - but as
this is not an extension, I have somewhat of an uneasy feeling to even
merge this without some at least rudimentary testing on "all" OSes. I am
confident it would probably work on most and can be fixed on the others
- but I see that as a TODO during the PR phase.

Speaking from a user PoV - if this simply doesn't work on some OSes for
no good reason.. that's a pretty leaky abstraction. If it's in the PHP
core, I'd assume it will work. Also I wouldn't count on it getting done,
just because there's one year of time and "we have no CI for that" is
not a good excuse in my book.

Don't get me wrong, this sounds like a useful feature - but (and my wild
guessing could be inaccurate) I think it's low-level enough that the
differences might matter.

Greetings,
Florian