Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:101146 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54815 invoked from network); 20 Nov 2017 20:35:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Nov 2017 20:35:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.216.180 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.216.180 mail-qt0-f180.google.com Received: from [209.85.216.180] ([209.85.216.180:44615] helo=mail-qt0-f180.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3A/40-48818-38C331A5 for ; Mon, 20 Nov 2017 15:35:15 -0500 Received: by mail-qt0-f180.google.com with SMTP id h42so16332644qtk.11 for ; Mon, 20 Nov 2017 12:35:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=azmjoVynYEkbV9F91E6rfI/NcuPTgc4aYt7Ar82szFU=; b=IkAnQxFYPwYDlBZ9iDXBE64P6eHN+8hGCoFloCKHI1J0eO8wUv003WZAoFA9sn4zCv Cj/BUHFZOdNAopbhiIbLUHsWNFhdIULQv6xAMUD5NjDTLIrAPdG6pop2WBxB4OdfLnHj xcLHBogE2RiXnH8lFTWjfx5W4XuQevHF0g5dq7uAhg5F1G+ptekdtsT7bWSgA9ql1l4i fSTrt+ZNfmpU4lDffOPtxtyr8ZbplLYfs0YjfsJsosEo7o9hYuKCsPIONoIMAlOQ3J7Q jQmOl6M4xFhVqnurWIi/XfHkTvZeJtrpV390lJJiI/sGzRf7TPi4wTONTA3Bj4yl7Ux5 ED+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=azmjoVynYEkbV9F91E6rfI/NcuPTgc4aYt7Ar82szFU=; b=Ow0dZ0wctBAhYYTrbju2vS7H2wxRZliRiS2IlGwiNGwDzTYHozfhDl4NuQkN6kIEOi OKukQ6OqPeXg3UDF/2dxsULkzGWZVdsxIn6V9yfhdbtXLmzgFa2ZdShUxY8lIr7LZK/G 9W9ruyQdKrlyWK7JtJWvkzR36VGRVg0a6IQG0vjvQ6g8FzWCUnqG0IR2sRIa4PcqLT+z fwITr8P0yeDMjjIcaNDI/9rljNWCVaKEu0QA8UmXVJ2oyj4AELTFBBEnFsSfkp/8/A+1 kzYLFc/ydcPMuFjAsLH6j/C6L6RGKPIx19+lJ0nFdp3ocUhOFktaOMaV+VVAydu05Umw lUEg== X-Gm-Message-State: AJaThX7gZOcg5Rr2DZCTjfcXUtcoxEhrGHqtfUjdZfiUikHrvSkAPVia rrBbSJG02mbdgqIa+1XdpM9hylH992MPQ45UG/g57Q== X-Google-Smtp-Source: AGs4zMZCbW+g5PmJS/SDLYPu4e9egVR/N4DqVRBlQtOEqpOqxNaHZ+jmDhww0b4qrTi8SFKikoUOoKav+3qJZxYnXsg= X-Received: by 10.200.37.157 with SMTP id e29mr5189485qte.108.1511210112406; Mon, 20 Nov 2017 12:35:12 -0800 (PST) MIME-Version: 1.0 Sender: php@golemon.com Received: by 10.12.158.145 with HTTP; Mon, 20 Nov 2017 12:35:11 -0800 (PST) X-Originating-IP: [206.252.215.26] In-Reply-To: References: <0C26068B-7CF6-41CE-AAE5-D7F3D71C8F6B@golemon.com> Date: Mon, 20 Nov 2017 15:35:11 -0500 X-Google-Sender-Auth: L7iR_DcluvMAkOW3wp9clH-77vg Message-ID: To: Dmitry Stogov Cc: "internals@lists.php.net" Content-Type: text/plain; charset="UTF-8" Subject: Re: Minor BC break in gettype() From: pollita@php.net (Sara Golemon) Good enough for me. Thanks! On Mon, Nov 20, 2017 at 2:13 AM, Dmitry Stogov wrote: > I think PHP 7.2 is a good place for these minor break. > > > Dmitry. > > ________________________________ > From: Sara Golemon > Sent: Saturday, November 18, 2017 12:17:24 PM > To: Dmitry Stogov; internals@lists.php.net > Subject: Minor BC break in gettype() > > https://3v4l.org/kRON7 > > https://github.com/php/php-src/commit/f00d1c72b4dbaf3532569d20efc1da7c408605d6 > > The above patch optimizes calls to gettype() into an opcode, however the > strings returned for closed resources has changed relative to 7.1 and > earlier. > > The newer output is objectively better, but it's technically a BC break. > > Was this intentional, and are we fine letting this change stand? > > -Sara