Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:101144 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21543 invoked from network); 20 Nov 2017 07:13:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Nov 2017 07:13:37 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain zend.com from 104.47.36.123 cause and error) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 104.47.36.123 mail-sn1nam02on0123.outbound.protection.outlook.com Received: from [104.47.36.123] ([104.47.36.123:47025] helo=NAM02-SN1-obe.outbound.protection.outlook.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0E/30-13822-F90821A5 for ; Mon, 20 Nov 2017 02:13:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=RWSoftware.onmicrosoft.com; s=selector1-zend-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IbP48c7auAtjsh5VOc5Y8ryPWIcbjZrNg4oSQEKDqi4=; b=IC/PMbm1racabo+BbGNgCjlT6P8H4D8Zvojxx0k5QSGpAvDZchPEdxf43LqafUcm9FBFI22jhRNE61h4pfCdAZAo3Kt3S7Zxa6qQCP17vsVGcLi3N6uF7O1hREj5bYF092CKeSem/UnGr9ZafjdvVsoAsKouUtrVxHoegzDLD+s= Received: from BN6PR02MB3234.namprd02.prod.outlook.com (10.161.152.32) by BN6PR02MB3233.namprd02.prod.outlook.com (10.161.152.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Mon, 20 Nov 2017 07:13:26 +0000 Received: from BN6PR02MB3234.namprd02.prod.outlook.com ([10.161.152.32]) by BN6PR02MB3234.namprd02.prod.outlook.com ([10.161.152.32]) with mapi id 15.20.0197.020; Mon, 20 Nov 2017 07:13:26 +0000 To: Sara Golemon , "internals@lists.php.net" Thread-Topic: Minor BC break in gettype() Thread-Index: AQHTYE4PYAEH4BdK7UyXM7GXp7Ey+KMc3PZC Date: Mon, 20 Nov 2017 07:13:26 +0000 Message-ID: References: <0C26068B-7CF6-41CE-AAE5-D7F3D71C8F6B@golemon.com> In-Reply-To: <0C26068B-7CF6-41CE-AAE5-D7F3D71C8F6B@golemon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dmitry@zend.com; x-originating-ip: [213.21.45.232] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR02MB3233;6:9c5TR1JfLYYlRJFu57kXJmUAHAFTNgOtYEIn0GugeJjtGVLVHB4NDh3DqBI97M5Os3xWYTNdg3EYVHf3rcCvUIrsmQ9Xv4oG/g6DBWOAVDD5oPJiwHr2CFTPPgZDlPLS92tul6fz5t5+7aPklXPj7DefAM3PIdQnTby4413/NObiWwhaTyzHxap1uiVmciwv2l21/jeGCsEyIkRaMeugcyL5IJKKynrWbpUTmzby46aJh6AMHEPMx0HEOKJaMVuzoivPUFBu394LEjVkKiKtDV8YjqBKqnS0MHiqXYercKVePnShyVZzB+rzl+VWZ4s2b56SUJd6jKj/Cgue3hx+nv9bpCyOcNre8yK1ZtsOZTk=;5:QQZDfOk9yRtLcb2c1oP3oKr8JAh+mnOotTiZWK1u/e+Y23jHvRvDHXm5qIeQKpXmwj4YnQZwNgy+lMCm/wEOiINAz5ZRbFO2UEbixdesLKYwL77GD++PoZlJkxjEbttoyUJXsKkF4phhN3tUPk1TqmrDUMMHPkgR3CGuoUP1rR4=;24:RIAnSA8qTSGoI80r2zy5eE6zJY//cyrGJUGLlvRNheMwfH8WEdcQW5qFJSV6ClF9wIuzOO1tsG6k6FSizIzT/KKXqtxb7uCf86ZzE1EfI/Q=;7:UpM1ZQZd6tqRPRXBGwa/y5oboMIWT+SR1pnPNIq5qmirgl7rKmDzedgq1Qzy2HbWSzMet/l8cXpeVwXMS9d6VTVLS/iGSOma2CqYY6UlYDTkiG+T80roJFR4YgwYUHc/AifjwMPNV2dVI1NVSTiIn/fPocqEvCtrpeT1qJal6V0RtjPRR8bUjYYbFxHJSUdS0lMyw6eluJgC2xcniBV/HpOelP7eglSbHYuFHLI94m93JSsKCNhPgfmZqyBv8VV0 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 148e3e33-0a01-40e5-6afc-08d52fe631b0 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:BN6PR02MB3233; x-ms-traffictypediagnostic: BN6PR02MB3233: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(226959545344774); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3231022)(3002001)(10201501046)(6041248)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR02MB3233;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR02MB3233; x-forefront-prvs: 04976078F0 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39830400002)(346002)(376002)(189002)(199003)(2501003)(14454004)(3660700001)(97736004)(33656002)(229853002)(966005)(3280700002)(6436002)(6506006)(77096006)(478600001)(110136005)(236005)(76176999)(9686003)(101416001)(68736007)(54356999)(8676002)(54896002)(81166006)(5660300001)(74316002)(50986999)(81156014)(8936002)(55016002)(99286004)(3846002)(53936002)(6246003)(102836003)(66066001)(2906002)(606006)(53546010)(25786009)(2950100002)(6306002)(189998001)(2900100001)(6606003)(86362001)(7696004)(19627405001)(316002)(106356001)(105586002)(7736002)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR02MB3233;H:BN6PR02MB3234.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: zend.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/alternative; boundary="_000_BN6PR02MB3234E41DAC81C635A0563FDABF220BN6PR02MB3234namp_" MIME-Version: 1.0 X-OriginatorOrg: zend.com X-MS-Exchange-CrossTenant-Network-Message-Id: 148e3e33-0a01-40e5-6afc-08d52fe631b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2017 07:13:26.2140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3233 Subject: Re: Minor BC break in gettype() From: dmitry@zend.com (Dmitry Stogov) --_000_BN6PR02MB3234E41DAC81C635A0563FDABF220BN6PR02MB3234namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think PHP 7.2 is a good place for these minor break. Dmitry. ________________________________ From: Sara Golemon Sent: Saturday, November 18, 2017 12:17:24 PM To: Dmitry Stogov; internals@lists.php.net Subject: Minor BC break in gettype() https://3v4l.org/kRON7 https://github.com/php/php-src/commit/f00d1c72b4dbaf3532569d20efc1da7c40860= 5d6 The above patch optimizes calls to gettype() into an opcode, however the st= rings returned for closed resources has changed relative to 7.1 and earlier= . The newer output is objectively better, but it's technically a BC break. Was this intentional, and are we fine letting this change stand? -Sara --_000_BN6PR02MB3234E41DAC81C635A0563FDABF220BN6PR02MB3234namp_--