Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101141
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <0C26068B-7CF6-41CE-AAE5-D7F3D71C8F6B@golemon.com>
References: <0C26068B-7CF6-41CE-AAE5-D7F3D71C8F6B@golemon.com>
Date: Sat, 18 Nov 2017 11:24:14 +0100
Message-ID: <CAF+90c88sHQWm-ad=5EVEYKOOAz=4cybJ6+BGBgW=AhSCLFphQ@mail.gmail.com>
To: Sara Golemon <php@golemon.com>
Cc: Dmitry Stogov <dmitry@zend.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="089e082cfc94457946055e3f4142"
Subject: Re: [PHP-DEV] Minor BC break in gettype()
From: nikita.ppv@gmail.com (Nikita Popov)

--089e082cfc94457946055e3f4142
Content-Type: text/plain; charset="UTF-8"

On Sat, Nov 18, 2017 at 10:17 AM, Sara Golemon <php@golemon.com> wrote:

> https://3v4l.org/kRON7
>
> https://github.com/php/php-src/commit/f00d1c72b4dbaf3532569d20efc1da
> 7c408605d6
>
> The above patch optimizes calls to gettype() into an opcode, however the
> strings returned for closed resources has changed relative to 7.1 and
> earlier.
>
> The newer output is objectively better, but it's technically a BC break.
>
> Was this intentional, and are we fine letting this change stand?
>
> -Sara


This is unrelated to the linked optimizations: The change was introduced in
https://github.com/php/php-src/commit/34824b70f8e72b200d77957145bb61883b03322d
and discussed as part of https://externals.io/message/94434. Another change
from the same thread is that is_object() now returns true for all objects,
including those of incomplete classes.

Nikita

--089e082cfc94457946055e3f4142--