Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:101140 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 22833 invoked from network); 18 Nov 2017 09:17:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Nov 2017 09:17:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 74.125.82.66 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 74.125.82.66 mail-wm0-f66.google.com Received: from [74.125.82.66] ([74.125.82.66:44571] helo=mail-wm0-f66.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4D/C4-59312-8AAFF0A5 for ; Sat, 18 Nov 2017 04:17:29 -0500 Received: by mail-wm0-f66.google.com with SMTP id r68so10522912wmr.3 for ; Sat, 18 Nov 2017 01:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=from:content-transfer-encoding:mime-version:date:subject:message-id :to; bh=QQcEAF6yc5pATXutCSfaOQXyAI98e8/HYS9YfSCTQfs=; b=iWzgM18xkLV15/GywmZfHF6As7fQe1nGU3N5mhTx+lkzn9TaTS8IIbQ1qd/KfjmRYf H9JhnrMNzHsvelvk/G6GpUJccJsK5Hkn5N6L4qiot1b5ojcBm5xcwrqZgHvxo4yvlIDA CuUAgaZNXskU5vgxcyTBVgu5Uf0jHTHYqDQe8soTaum8ozltvT+eCkhK1D3BaTd7aLO1 Hxy9aePEp4GeZXxjLOCSj9QhdxfEQDTnTj+6y1cjd/8aOBv2wB5CNvfPbeB5AEvi9DVA 0uym7NtMkvoLIMwSzeu0z0C0eI5UIdeNCC0srpsmvhM6wAJhY3yP5FzGQgHjHdm1wd7C X0jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version:date :subject:message-id:to; bh=QQcEAF6yc5pATXutCSfaOQXyAI98e8/HYS9YfSCTQfs=; b=bTl4MM0nBwzTepHd4eUCdRmhBliZ1MR8g0aVojKZtTqXt3C5F9Zky9Tsfl91BVH6j/ tmwbVvHWiNZZ3SsiNZ0SEk8rFMlJWUa4i5+zxuY41dCUVXsRFjzMMfIrSsNk+n5pjD7U hzJ5Fpf3zRjOarXgAoH29YbuOeBKFLQ/c708cn4IYuoEnB1QxmCXrz0jCdHU9aW5QFFL lZAGy9ngyZpL18wdgeUqHrzn323olAs9q26/WVaGHrAfQq8+X8s5Nt86pjcCP9+F1/H9 q67B9bmSW7xOaofPDHyxU9nwZzhTvuVG2Ipqdt53dwdGSZHhjuJZdOmeW5851b8Hqbg3 w49Q== X-Gm-Message-State: AJaThX59qAwlCIucn+cj5EkkTPeRRaNIOnW1ai4OG6Iww7X4JHy/grdG 9v0du7YaT9GDCCPxNTuXjly8Lw== X-Google-Smtp-Source: AGs4zMYwqsjbHJdwEhqmhUG4NYv9t4/O1yCuhKzMJYtUZ272SEGVSv0WPi/Hn1m39XF2Oyl5gswxdg== X-Received: by 10.80.182.217 with SMTP id f25mr11255051ede.104.1510996646377; Sat, 18 Nov 2017 01:17:26 -0800 (PST) Received: from [192.168.5.195] ([83.103.155.160]) by smtp.gmail.com with ESMTPSA id p7sm3983132edj.5.2017.11.18.01.17.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2017 01:17:25 -0800 (PST) Content-Type: multipart/alternative; boundary=Apple-Mail-2B9D000E-580A-4EA8-B8CB-DDBE52A8CDEE Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (1.0) Date: Sat, 18 Nov 2017 11:17:24 +0200 Message-ID: <0C26068B-7CF6-41CE-AAE5-D7F3D71C8F6B@golemon.com> To: Dmitry Stogov , internals@lists.php.net X-Mailer: iPhone Mail (14E304) Subject: Minor BC break in gettype() From: php@golemon.com (Sara Golemon) --Apple-Mail-2B9D000E-580A-4EA8-B8CB-DDBE52A8CDEE Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable https://3v4l.org/kRON7 https://github.com/php/php-src/commit/f00d1c72b4dbaf3532569d20efc1da7c408605= d6 The above patch optimizes calls to gettype() into an opcode, however the str= ings returned for closed resources has changed relative to 7.1 and earlier. The newer output is objectively better, but it's technically a BC break. Was this intentional, and are we fine letting this change stand? -Sara= --Apple-Mail-2B9D000E-580A-4EA8-B8CB-DDBE52A8CDEE--