Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101064
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lvht.net from 54.204.34.130 cause and error)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.11\))
In-Reply-To: <6B9B9796-F66E-45EC-B5CC-58051170F2F2@lvht.net>
Date: Sun, 5 Nov 2017 21:04:10 +0800
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <79BC6B21-2A9E-4A2E-9858-33EA4019CA37@lvht.net>
References: <736B46E8-9458-4E63-8BB7-AF93A8C35F58@lvht.net>
 <BN6PR02MB3234253A0C2D4015781B241CBF5F0@BN6PR02MB3234.namprd02.prod.outlook.com>
 <F5BEA807-6082-4B0C-AC83-C5625782766F@lvht.net>
 <6B9B9796-F66E-45EC-B5CC-58051170F2F2@lvht.net>
To: Dmitry Stogov <dmitry@zend.com>
Feedback-ID: bizesmtp:lvht.net:qybgforeign:qybgforeign4
Subject: Re: [PHP-DEV] RFC - Zend VM Pause API 
From: i@lvht.net (Haitao Lv)

After discussion with Dmitry, I update my RFC. The RFC url is here

https://wiki.php.net/rfc/zend-vm-pause-api

And I propose to introduce a new interrupt type to make vm =
pause-and-return, not pause-and-continue.

As mentioned by Dmitry, features like Fiber could be implemented by =
current vm_interrupt implementation, theoretically. By using it, even =
init a function call will need to make our own op array.

So I propose this patch.

Thank you.


> On 1 Nov 2017, at 17:13, Haitao Lv <i@lvht.net> wrote:
>=20
> Would it proper to introduce the following path?
>=20
> diff --git a/Zend/zend_vm_def.h b/Zend/zend_vm_def.h
> index 9bed9f86bb..cf0935df74 100644
> --- a/Zend/zend_vm_def.h
> +++ b/Zend/zend_vm_def.h
> @@ -8920,13 +8920,19 @@ ZEND_VM_DEFINE_OP(137, ZEND_OP_DATA);
>=20
> ZEND_VM_HELPER(zend_interrupt_helper, ANY, ANY)
> {
> +       int8_t interrupt_type =3D EG(vm_interrupt);
> +
>        EG(vm_interrupt) =3D 0;
>        if (EG(timed_out)) {
>                zend_timeout(0);
>        } else if (zend_interrupt_function) {
>                SAVE_OPLINE();
>                zend_interrupt_function(execute_data);
> -               ZEND_VM_ENTER();
> +               if (interrupt_type =3D=3D 2) {
> +                       ZEND_VM_RETURN();
> +               } else {
> +                       ZEND_VM_ENTER();
> +               }
>        }
>        ZEND_VM_CONTINUE();
> }
>=20
>> On 1 Nov 2017, at 16:54, Haitao Lv <i@lvht.net> wrote:
>>=20
>> It seems that set EG(vm_interrupt) to 1 could not stop the vm =
execution but only execute the interrupt_function and continue the =
current execution.
>>=20
>> However, my RFC propose to stop the current execution.
>>=20
>>> On 1 Nov 2017, at 16:07, Dmitry Stogov <dmitry@zend.com> wrote:
>>>=20
>>> Hi,
>>>=20
>>> It should be possible do similar things using EG(vm_interrupt) and =
zend_interrupt_function() callback (introduced in php-7.1)
>>> ext/pcntl implements asynchronous signal handling using this.
>>>=20
>>> Thanks. Dmitry.
>>> From: Haitao Lv <i@lvht.net>
>>> Sent: Wednesday, November 1, 2017 4:19:07 AM
>>> To: PHP Internals
>>> Subject: [PHP-DEV] RFC - Zend VM Pause API=20
>>>=20
>>> Hi, internals,
>>>=20
>>> I propose to introduce a new zend vm pause api, and here is the RPF
>>>=20
>>> https://wiki.php.net/rfc/zend-vm-pause-api =
<https://wiki.php.net/rfc/zend-vm-pause-api>
>>>=20
>>> Please gave your comment.
>>>=20
>>> Thank you.
>>>=20
>>>=20
>>>=20
>>> --=20
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php =
<http://www.php.net/unsub.php>
>=20
>=20
>=20
>=20
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php