Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101024
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.192.169 cause and error)
MIME-Version: 1.0
In-Reply-To: <1f9f3be9-532e-533e-ecef-bf567d416941@oracle.com>
References: <AM4PR0901MB1265FE4EA7C9DBD36CF6CF7CF95F0@AM4PR0901MB1265.eurprd09.prod.outlook.com>
 <f21fe093-a1fd-979c-73c5-9c22d8a0a6a3@gmail.com> <1f9f3be9-532e-533e-ecef-bf567d416941@oracle.com>
Date: Wed, 1 Nov 2017 23:36:33 +0000
Message-ID: <CA+kxMuTjYuMy+VG9Tok=dHWDSgJ2sQusvXq_L+0s5LWqHh-DhQ@mail.gmail.com>
To: Christopher Jones <christopher.jones@oracle.com>, Stanislav Malyshev <smalyshev@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC][VOTE] Flexible Heredoc and Nowdoc Syntaxes
From: danack@basereality.com (Dan Ackroyd)

Stanislav Malyshev <smalyshev@gmail.com> wrote:
>
> Something I am missing here. RFC is talking about removing indents from
> heredoc text, but the vote says "Allow for the closing marker to be
> indented?" and does not mention that indenting closing marker also
> changes how the rest of the heredoc is parsed. Is this still the case?


From the body of the RFC:

"To enable for the closing marker to be indented, ... The indentation
of the closing marker dictates the amount of whitespace to strip from
each line within the heredoc/nowdoc"

That's about 3 lines of text into the RFC. Presumably the RFC didn't
think the whole concept being voted on needed to be repeated in the
voting option. Perhaps it should have been but:

Christopher Jones wrote:
> I'm going to have to assume so and vote No.

It is better to ask questions during the discussion phase of an RFC,
but if you do have a question during the voting period, you're still
allowed to ask rather than voting based on assumptions.

> PS. RFC writers: please take care when writing specs.

Please don't use passive aggressive 'helpful hints' like this. For example:

"RFC voters - please read the RFC during the RFC period and ask
questions then. ;-)" is an irritating way of writing this.

A way of writing it that is more conducive to a productive discussion is:

I think this is covered in the RFC text. Does the line I picked out
above, give a clear description for what that vote is for?

cheers
Dan
Ack