Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:101014
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 104.47.42.128 cause and error)
To: Haitao Lv <i@lvht.net>
CC: PHP Internals <internals@lists.php.net>, Nikita Popov
	<nikita.ppv@gmail.com>, Bob Weinand <bobwei9@hotmail.com>
Thread-Topic: [PHP-DEV] RFC - Zend VM Pause API 
Thread-Index: AQHTUq+MRlKJxgZnpUWrjGakEM4VPKL/Kb/IgAAPDQCAAARLE4AABjkAgAADi4CAAAIcew==
Date: Wed, 1 Nov 2017 10:15:12 +0000
Message-ID: <BN6PR02MB323456630CC60A7553EAF149BF5F0@BN6PR02MB3234.namprd02.prod.outlook.com>
References: <736B46E8-9458-4E63-8BB7-AF93A8C35F58@lvht.net>
 <BN6PR02MB3234253A0C2D4015781B241CBF5F0@BN6PR02MB3234.namprd02.prod.outlook.com>
 <F5BEA807-6082-4B0C-AC83-C5625782766F@lvht.net>
 <BN6PR02MB32345A3C6EBD63707B32F51BBF5F0@BN6PR02MB3234.namprd02.prod.outlook.com>
 <358E7BE8-F3D3-47BC-AD44-21B0A9D4ABA5@lvht.net>,<0C785312-A09B-4E44-A1F2-40964C5AECBF@lvht.net>
In-Reply-To: <0C785312-A09B-4E44-A1F2-40964C5AECBF@lvht.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BN6PR02MB323456630CC60A7553EAF149BF5F0BN6PR02MB3234namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 98b9ddf9-e068-4545-721b-08d52111701a
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2017 10:15:12.0328
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3234
Subject: Re: [PHP-DEV] RFC - Zend VM Pause API 
From: dmitry@zend.com (Dmitry Stogov)

--_000_BN6PR02MB323456630CC60A7553EAF149BF5F0BN6PR02MB3234namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

I'm not sure, why do you need to exit from the current VM instance.

It should be possible to perform fiber scheduling and VM context switch dir=
ectly in interrupt handler (like in real OS).

VM should handle this out of the box (at least VM interrupts were designed =
with context switch in mind).


In your case, I suppose, part of zend_fiber_resume() should be merged into =
fiber_interrupt_function().

Also you should handle only your own interrupts (like ext/pcntl does checki=
ng PCNTL_G(pending_signals)).


Sorry, I don't have a lot of time to review your sources.

However, the implementation is really interesting, and I'm glad, someone is=
 working on this.


Thanks. Dmitry.

________________________________
From: Haitao Lv <i@lvht.net>
Sent: Wednesday, November 1, 2017 12:45:13 PM
To: Dmitry Stogov
Cc: PHP Internals
Subject: Re: [PHP-DEV] RFC - Zend VM Pause API

To make the discussion more detailed, please allow me to offer my implement=
ation of use land coroutine(Fiber).

https://github.com/php/php-src/compare/master...fiberphp:fiber-ext?expand=
=3D1


> On 1 Nov 2017, at 17:32, Haitao Lv <i@lvht.net> wrote:
>
> Suppose we have a internal Coroutine class and it has a resume() method.
>
> In order to resume the coroutine, we have to call the resume() function.
>
> As the resume function is a internal method defined in c, we need call
>
> zend_execute_ex(backuped_execute_data)
>
> to resume the zend execution.
>
> If we need to pause the coroutine, we set the EG(vm_interrupt) and interr=
upt_function,
> and switch the execute data and stack. The zend vm will execute the old o=
nline.
>
> However, we will never see the resume() method returned and never get its=
 return value.
>
>> On 1 Nov 2017, at 17:14, Dmitry Stogov <dmitry@zend.com> wrote:
>>
>> after zend_interrupt_function() callback VM continues execution using EG=
(current_execute_data).
>> callback may modify it in any way (e.g. unwind stack, or switch to anoth=
er co-routine or continuation).
>>
>> Thanks. Dmitry.
>> From: Haitao Lv <i@lvht.net>
>> Sent: Wednesday, November 1, 2017 11:54:54 AM
>> To: Dmitry Stogov
>> Cc: PHP Internals
>> Subject: Re: [PHP-DEV] RFC - Zend VM Pause API
>>
>> It seems that set EG(vm_interrupt) to 1 could not stop the vm execution =
but only execute the interrupt_function and continue the current execution.
>>
>> However, my RFC propose to stop the current execution.
>>
>>> On 1 Nov 2017, at 16:07, Dmitry Stogov <dmitry@zend.com> wrote:
>>>
>>> Hi,
>>>
>>> It should be possible do similar things using EG(vm_interrupt) and zend=
_interrupt_function() callback (introduced in php-7.1)
>>> ext/pcntl implements asynchronous signal handling using this.
>>>
>>> Thanks. Dmitry.
>>> From: Haitao Lv <i@lvht.net>
>>> Sent: Wednesday, November 1, 2017 4:19:07 AM
>>> To: PHP Internals
>>> Subject: [PHP-DEV] RFC - Zend VM Pause API
>>>
>>> Hi, internals,
>>>
>>> I propose to introduce a new zend vm pause api, and here is the RPF
>>>
>>> https://wiki.php.net/rfc/zend-vm-pause-api
>>>
>>> Please gave your comment.
>>>
>>> Thank you.
>>>
>>>
>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>




--_000_BN6PR02MB323456630CC60A7553EAF149BF5F0BN6PR02MB3234namp_--