Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100997 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85348 invoked from network); 30 Oct 2017 18:59:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2017 18:59:18 -0000 Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.216.173 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.216.173 mail-qt0-f173.google.com Received: from [209.85.216.173] ([209.85.216.173:46267] helo=mail-qt0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 81/BC-07742-48677F95 for ; Mon, 30 Oct 2017 13:59:16 -0500 Received: by mail-qt0-f173.google.com with SMTP id 1so17763425qtn.3 for ; Mon, 30 Oct 2017 11:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3xnmqSXxpRbGUVRJMxLFOV5YsjXY5HyQSM7a45BhYpg=; b=B/aQk/WtRwO9Ky+k9wxiaU4fWUXnwIc2XSZJVo9KrJKOUDCzr5XXo54lzTzIRsYAAr 9xxyYXQL1L9K8J2WzfWRKI+jFbEvN5A3ZY7bagUFYsoFEXjs2EyJ8iWjKwZPYtlyJW7k BSJUMwN2VblVPTf25BoU3/fcTc6lsLAtePjAcqp7/gQPAWQKa4zdhFrKOhF5LDMd2JYc 6O5DNVN52n2kZSBjh1ZaDjShXHXKRQTjfzhj30rCUWm3wiF0ljiiPrQyKJGtgMLs45g4 mfvOBE6ZyoJbTzF8W4rV+nPqyxWsIy7qZ6HcjtrBwXPx7JfNbx3t1wFGu0UuVvvIlmxH xIug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3xnmqSXxpRbGUVRJMxLFOV5YsjXY5HyQSM7a45BhYpg=; b=JGx9l3zm1LHuHBPVX4zMGQXptf1nBtxPB/9MEuvmdqbbHYBVvxP/06Z0+q5fmOcRMy Lh8646QAlPzPaPqkp9P2Kjcau9F5bbKMabrS6MAk15PGMUQj6HzEpoGw2xXwY47NdyvU uhWTfWg7gpVx5i+k23OwOX1LUhDn4AJ7Xkz5NZgUU/nryt85Zu13CNwEEcVtjQ1tkoSN jpw4vN+kPJXF4nRxnyLzNV/Kho8pn0NnN2cmfNuXOvpgNey0dqboS8xPbOrFhvQDoT6g 5wT9FtXZXvlsr6B7I+KxFcDASitXo1j3xIFtmQsivbS3yS0V6voZxdl8bEXVd1eaDD7G fOGg== X-Gm-Message-State: AMCzsaVmZs0psVC8P4q1IIBdTl30a6nHZD1V5b29r8LpMpFE1HjetsqL 79oWdfenxRS3LF8HpR/DuYlbJkRl/CKIwwAKU7UTIg== X-Google-Smtp-Source: ABhQp+SeZw48He+30uyfUhSkLfL0B00Mwo3Hipy8SwmfHKXirUhQuo7Q1bwux9r2YWrcxIdQlO2kH5dkZBrD7PGjPO8= X-Received: by 10.200.50.193 with SMTP id a1mr15522088qtb.94.1509389953415; Mon, 30 Oct 2017 11:59:13 -0700 (PDT) MIME-Version: 1.0 Sender: php@golemon.com Received: by 10.12.156.1 with HTTP; Mon, 30 Oct 2017 11:59:12 -0700 (PDT) X-Originating-IP: [206.252.215.26] In-Reply-To: References: Date: Mon, 30 Oct 2017 14:59:12 -0400 X-Google-Sender-Auth: gq5N1kfqmCO6wcNd9dGrM2Hp02Y Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Consistent indentation for test files From: pollita@php.net (Sara Golemon) On Sat, Oct 28, 2017 at 7:59 AM, Nikita Popov wrote: > Right now we do not have a consistent standard for the indentation of > PHPT files. > > I would like to propose that we establish a common standard > Not for nothin', but PSR-2 exists. If we adopt *any* standard, I think it should be this one* (which is a spiritual successor to PEAR's CS fwiw). > +1 but it needs to be done in the lowest active branch > otherwise it will result in conflicts when changing > existing tests (it is sometimes useful for extending tests)... > I'm not convinced that test files are in such an active state of churn that this would net us much benefit for the cost. -Sara * PSR-12 is in the works as an update to PSR-2, but the items it addresses are largely orthogonal to the kind of code you find in PHPT files.