Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100995 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 78290 invoked from network); 30 Oct 2017 17:47:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2017 17:47:17 -0000 Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Received: from [82.113.146.227] ([82.113.146.227:44158] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F4/7B-07742-2A567F95 for ; Mon, 30 Oct 2017 12:47:14 -0500 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id BB4FB10C83A; Mon, 30 Oct 2017 17:47:10 +0000 (GMT) Date: Mon, 30 Oct 2017 17:47:10 +0000 (GMT) X-X-Sender: derick@singlemalt.home.derickrethans.nl To: Jakub Zelenka cc: Nikita Popov , PHP internals In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [PHP-DEV] Consistent indentation for test files From: derick@php.net (Derick Rethans) On Sun, 29 Oct 2017, Jakub Zelenka wrote: > On Sat, Oct 28, 2017 at 12:59 PM, Nikita Popov wrote: > > Here are the current statistics for code in .phpt files: > > > > total: 15515 > > prefer tabs: 4273 (27.5%) > > prefer spaces: 6307 (40.7%) > > draw: 77 (0.5%) > > no indentation: 4858 (31.3%) > > > > There are 1824 (11.8%) files that contain mixed tab and space indentation. > > The indentation was determined based on the first character of a line. > > > > I would like to propose that we establish a common standard by > > a) using space indentation for all future tests (as they currently form the > > majority), and > > I usually use tabs for phpt as it's a bit simpler with my IDE that I use > for PHP core dev (QtCreator) and mostly the core exts that I work with had > tabs. That said I wouldn't be against making it the same and use spaces > everywhere if we also start using PSR-2 for tests - it's not just an > indentation that is a mess... > > > b) reindenting existing test files to use space indentation. > > > +1 but it needs to be done in the lowest active branch otherwise it will > result in conflicts when changing existing tests (it is sometimes useful > for extending tests)... I'm -1 on the whole exercise, but this comment by Jakub is what worries me most. cheers, Derick -- https://derickrethans.nl | https://xdebug.org | https://dram.io Like Xdebug? Consider a donation: https://xdebug.org/donate.php twitter: @derickr and @xdebug