Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100994
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAESVnVocEitrBQqsaEYF-C_Oy0kpEPJh_qn1Wa7J_6=+tjdmXw@mail.gmail.com>
References: <20171027121225.2AAC95FB05@mx.zeyos.com> <CAESVnVrbEYuFLAPFrkssL08KrEFrGyciQwPemaU06SHieT60=w@mail.gmail.com>
 <CAF+90c_xYPvE72s7pSnKdmrMcUOCTsjyPfr2VoM9t47utbG-EA@mail.gmail.com>
 <CAESVnVrGUAmE2HD7M=R3vbora4S8-65FtEV0XrfrKBTsiOn--Q@mail.gmail.com>
 <BN6PR02MB3234032488352B1AE6E99C48BF590@BN6PR02MB3234.namprd02.prod.outlook.com>
 <CAESVnVocEitrBQqsaEYF-C_Oy0kpEPJh_qn1Wa7J_6=+tjdmXw@mail.gmail.com>
Date: Mon, 30 Oct 2017 16:17:48 +0100
Message-ID: <CAF+90c_4=yKjM3bgFaV+sdTBVH8rO67J=D5A3YAu7KfYdRB5Wg@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Dmitry Stogov <dmitry@zend.com>, Benjamin Coutu <ben.coutu@zeyos.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a113f2c242ccba6055cc5244b"
Subject: Re: [PHP-DEV] Apply substr() optimization to array_slice()
From: nikita.ppv@gmail.com (Nikita Popov)

--001a113f2c242ccba6055cc5244b
Content-Type: text/plain; charset="UTF-8"

On Mon, Oct 30, 2017 at 4:09 PM, Sara Golemon <pollita@php.net> wrote:

> On Mon, Oct 30, 2017 at 6:51 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> > The optimization also broke Zend/tests/bug72598.phpt and
> Zend/tests/bug72598_2.phpt
> >
> Damn.  I had a feeling references would rear their ugly head here.
>
> Fuggit, reverted.  We can take another swing at it later, but it's not
> a vital optimization.
>
> -Sara
>

This is really more of a bug in call_user_func_array(). It should be
treating rc=1 references as non-references and throw a warning in that case
as well. That may not be very popular behavior though...

Nikita

--001a113f2c242ccba6055cc5244b--