Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100993
Return-Path: <php@golemon.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 59180 invoked from network); 30 Oct 2017 15:09:26 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Oct 2017 15:09:26 -0000
Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail
Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.178 as permitted sender)
X-PHP-List-Original-Sender: php@golemon.com
X-Host-Fingerprint: 209.85.220.178 mail-qk0-f178.google.com  
Received: from [209.85.220.178] ([209.85.220.178:57119] helo=mail-qk0-f178.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id B1/48-07742-5A047F95 for <internals@lists.php.net>; Mon, 30 Oct 2017 10:09:26 -0500
Received: by mail-qk0-f178.google.com with SMTP id l194so16488098qke.13
        for <internals@lists.php.net>; Mon, 30 Oct 2017 08:09:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=golemon-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc;
        bh=Y6HPDuTO69AGpXE6kgOjhb0Q2CXblCQmtGJFZKhI7fI=;
        b=JvsN/x/X6oBjRcQ1+sE7jqRbl8sexsECACEN5wDPlVHEXKix26iAwgv3k1Vrd0ZVPg
         Yv7JNtmY4j/dcH/I3ajWcdP6/GI+B8iQLg+0D910cJCu1JevfpmLV7wpAZjbdH0W9ngE
         THaQFKnPgX913lC3h2GElTko/6JaJxbTcdBM4sfWPXtVPqJKSdmCyVd0zbuJhRB586Ir
         DfJr/LKAP09p14SockIetqNlUvopjC72h93XXvrWfx0o47mjzSkRmys3WrmyfF5Wg5/t
         Rd3ZUPaiLxBHzTaOHUkYOfr29lrCH3Y/HVvGhlQy/W8ppQF7bFVWV4rVluxbkz3LsHXw
         OnuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
         :date:message-id:subject:to:cc;
        bh=Y6HPDuTO69AGpXE6kgOjhb0Q2CXblCQmtGJFZKhI7fI=;
        b=JGeWGqwmIldgUEeQLmBiogKBZmNFuS9FWQ0HwAlia14kgw5azfNpRs1fcYumemj6no
         X2fP82JLs21Pyoh1m5VPcnqGDSaY0PcdH3wVQXw06Ll2ORTT/34kOJk7Q5iEsH5r3E02
         KjYN8QKVuXREZR8qMJOWu0jPmgWb/+eM/rDGJKyW7HE64oul6yj/8MkohW02g/uLlcyf
         nI51ICktiVucHcIdD8cHbuBfZ/7zoQoXxaHqRPr0DVojteQE+gnPTavjVcQcBqCd6swG
         JjJm060U9eYx/62Uh+xmoIM4odV7r69xr5/SqsBP60EeBlr6cWD3bImAw7V5UZTXOoOx
         nTxA==
X-Gm-Message-State: AMCzsaWVYqfkY+WVGlQCcDv4dUDcwxp4H1jyhJLPI/RQT7pipOsWZ8gP
	DzkTMQH/klBycsQlCRYtl214F1aZuNLSsGb0ohJavw==
X-Google-Smtp-Source: ABhQp+RqSMC7+8IuwLFkLEep7kNXSwv0YiGgDADsJSk0jCeaNmh7/MM6S/XT7XP2SoI8QYb4QHs2IoAs8gXzkSiSsDo=
X-Received: by 10.55.18.13 with SMTP id c13mr13777184qkh.81.1509376163419;
 Mon, 30 Oct 2017 08:09:23 -0700 (PDT)
MIME-Version: 1.0
Sender: php@golemon.com
Received: by 10.12.156.1 with HTTP; Mon, 30 Oct 2017 08:09:22 -0700 (PDT)
X-Originating-IP: [206.252.215.26]
In-Reply-To: <BN6PR02MB3234032488352B1AE6E99C48BF590@BN6PR02MB3234.namprd02.prod.outlook.com>
References: <20171027121225.2AAC95FB05@mx.zeyos.com> <CAESVnVrbEYuFLAPFrkssL08KrEFrGyciQwPemaU06SHieT60=w@mail.gmail.com>
 <CAF+90c_xYPvE72s7pSnKdmrMcUOCTsjyPfr2VoM9t47utbG-EA@mail.gmail.com>
 <CAESVnVrGUAmE2HD7M=R3vbora4S8-65FtEV0XrfrKBTsiOn--Q@mail.gmail.com> <BN6PR02MB3234032488352B1AE6E99C48BF590@BN6PR02MB3234.namprd02.prod.outlook.com>
Date: Mon, 30 Oct 2017 11:09:22 -0400
X-Google-Sender-Auth: rsIMCtHksY4wvMPSObyvHVva5fA
Message-ID: <CAESVnVocEitrBQqsaEYF-C_Oy0kpEPJh_qn1Wa7J_6=+tjdmXw@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Benjamin Coutu <ben.coutu@zeyos.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Apply substr() optimization to array_slice()
From: pollita@php.net (Sara Golemon)

On Mon, Oct 30, 2017 at 6:51 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> The optimization also broke Zend/tests/bug72598.phpt and Zend/tests/bug72598_2.phpt
>
Damn.  I had a feeling references would rear their ugly head here.

Fuggit, reverted.  We can take another swing at it later, but it's not
a vital optimization.

-Sara