Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100990
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <400665f7-3efa-8308-aff2-b721f9c7a601@gmx.de>
References: <CAF+90c_0RNfYDU25Os0azb2irnkV5N943KN76+WhO-iCxR+6Gg@mail.gmail.com>
 <400665f7-3efa-8308-aff2-b721f9c7a601@gmx.de>
Date: Mon, 30 Oct 2017 01:38:40 -0700
Message-ID: <CAKOpQSy11x1sZUJYhpFw2dhYMT-ayoZvBhzFJkwBLxAXRCSvUA@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c0e71fcc6ab53055cbf9075"
Subject: Re: [PHP-DEV] Re: Consistent indentation for test files
From: kris.craig@gmail.com (Kris Craig)

--94eb2c0e71fcc6ab53055cbf9075
Content-Type: text/plain; charset="UTF-8"

On Sat, Oct 28, 2017 at 5:42 AM, Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> On 28.10.2017 at 13:59, Nikita Popov wrote:
>
> > Right now we do not have a consistent standard for the indentation of
> PHPT
> > files. Some people create space-indented files, others create
> tab-indented
> > files. Over time, indentation invariably starts to mix, because
> developers
> > with different indentation settings work on one file.
> >
> > Here are the current statistics for code in .phpt files:
> >
> > total: 15515
> > prefer tabs: 4273 (27.5%)
> > prefer spaces: 6307 (40.7%)
> > draw: 77 (0.5%)
> > no indentation: 4858 (31.3%)
> >
> > There are 1824 (11.8%) files that contain mixed tab and space
> indentation.
> > The indentation was determined based on the first character of a line.
>
> Thanks for bringing this up!
>
> > I would like to propose that we establish a common standard by
> > a) using space indentation for all future tests (as they currently form
> the
> > majority), and
> > b) reindenting existing test files to use space indentation.
>
> +1
>
> I'm rather baffled that <http://qa.php.net/write-test.php> doesn't
> address this issue at all.
>
> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Those stats can be a bit misleading, though, as I've observed that many (if
not most) IDEs are configured to automatically convert tab characters to
spaces.  Therefore, it stands to reason that at least some of the "prefer
spaces" category would actually fall under "prefer tabs".  I suspect the
tabs and spaces groups are much closer together, though it's impossible to
say how much since there's no way to control for that variable.  Still, I
would caution people not to read too much into those statistics.

A common standard would be nice, but I fear it might discourage some from
contributing tests.  Also, how would we actually enforce this?  Would we
reject any tests that don't conform to this or fix them, ourselves?  Either
way, it would require someone to actually do the work.  Another possible
option would be to use some kind of automated conversion process.  But I
personally think these solutions are more trouble than they're worth.  So
long as the spacing is consistent within each file, I can live with it.

--Kris

--94eb2c0e71fcc6ab53055cbf9075--