Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100986 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20027 invoked from network); 30 Oct 2017 05:01:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2017 05:01:31 -0000 Authentication-Results: pb1.pair.com header.from=kalle.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=kalle.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.193 as permitted sender) X-PHP-List-Original-Sender: kalle.php@gmail.com X-Host-Fingerprint: 209.85.223.193 mail-io0-f193.google.com Received: from [209.85.223.193] ([209.85.223.193:43836] helo=mail-io0-f193.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DC/F2-07742-922B6F95 for ; Mon, 30 Oct 2017 00:01:30 -0500 Received: by mail-io0-f193.google.com with SMTP id 134so24363981ioo.0 for ; Sun, 29 Oct 2017 22:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=e/dO04yTV6OaZveTFgpzPs/1Flxn+cvL4PuE0+TU22Q=; b=S+EE/FPkbGU4qnMTJ5CRfqT+pCihpUBlU/vmR/mP8WD0G82WFnh7wWPtZQ2d5wrGLM 2mGaN1DNIw90suYAbX9p9B2cIzbYpFJoKxLkSHlNqbKZxSHcZ36+SjGeg65s4m+Gogni 75n0hCMSbhMvYQwc4zXyYdEAbpB4uLnmfv2eZ8FD/KPwOrNPnWpRQykCgXhaJlSGg5W4 2Tuq7ScvyJkJq7bw3ApsZ0iJZV2JSJeQst9/65+qZH0hHOug8Wz87JzicK9UrH3prWte NzY7NVyLVyE27Ewzf1QHm5OYhBY7/B6HgybDuLiNliFU6aYPVYnq36UpeAI6MJTru0N3 jWgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=e/dO04yTV6OaZveTFgpzPs/1Flxn+cvL4PuE0+TU22Q=; b=am0ZTPV2fwEKu9jsZE0N/t8KwqbH5uhTjjGd7fPrb3k60+AvvmcXDYkk+DF5LmnUDL M7MgxHg+UWOh2YWa/ECNGvekX8VG9Wvjp0i9VMWaGplO3x3+ziLPLj82qO+D+BUESx02 JSfD0vECkEr+pxdWYSEQW2DRveltDs06RkiS219/My5sC4Q2wDr8cTtsJDVg5KyLYe7V sFrPANaOdkSlWBq3WgP6vc0T+LRiNt+DKkjtODWv10ZjDXIdus1tRMFugQnI/B3gLmu5 go5YaFcz7LoakXy8Wp/N3INROk3z6kGy/y6kGOVfofQTxE9azTi6aoxtw/WYXO53ynLS FjNw== X-Gm-Message-State: AMCzsaUx0a1YHbd5sVuYPtbz3fW3DkupKCwz59tEC8krxjYS9rneqvs/ TJ+YQoZqcsP8MLjI+LYRGKaqtq97QHKa8g5UFdU= X-Google-Smtp-Source: ABhQp+S/2H/ZZVDxjDRRkknOqV0YL/TLDuTshn0Ubx9uX1pHDUNv+z9wgoOe25rV8c+gje8cnWUxeduyZXZn25cDmek= X-Received: by 10.36.3.202 with SMTP id e193mr4556025ite.108.1509339686466; Sun, 29 Oct 2017 22:01:26 -0700 (PDT) MIME-Version: 1.0 Sender: kalle.php@gmail.com Received: by 10.107.7.106 with HTTP; Sun, 29 Oct 2017 22:01:26 -0700 (PDT) In-Reply-To: References: Date: Mon, 30 Oct 2017 06:01:26 +0100 X-Google-Sender-Auth: Rxk8ZmAZBJaLY4VTeuLORCidlZg Message-ID: To: Anatol Belski Cc: Jakub Zelenka , Nikita Popov , PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Consistent indentation for test files From: kalle@php.net (Kalle Sommer Nielsen) 2017-10-29 22:30 GMT+01:00 Anatol Belski : > Whichever way would be chosen, implementing a pre commit hook would make sense to be done. To mention, tabs were easier for me, too, but not a big deal anyway. I'm on the same boat as Anatol here, whatever is choosen is fine with me, tho I generally tend to use tabs unless the test I copy/pasted had spaces, I would follow that. -- regards, Kalle Sommer Nielsen kalle@php.net