Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100982
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.172 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <CAF+90c_0RNfYDU25Os0azb2irnkV5N943KN76+WhO-iCxR+6Gg@mail.gmail.com>
References: <CAF+90c_0RNfYDU25Os0azb2irnkV5N943KN76+WhO-iCxR+6Gg@mail.gmail.com>
Date: Sun, 29 Oct 2017 18:41:23 +0000
Message-ID: <CAEKnhAE=Q+SSA3oAOm5TaDe6bJwCgVrGpHNjB01AA15LdbQPWA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a114e5e146e8475055cb3ded5"
Subject: Re: [PHP-DEV] Consistent indentation for test files
From: bukka@php.net (Jakub Zelenka)

--001a114e5e146e8475055cb3ded5
Content-Type: text/plain; charset="UTF-8"

On Sat, Oct 28, 2017 at 12:59 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals,
>
> Right now we do not have a consistent standard for the indentation of PHPT
> files. Some people create space-indented files, others create tab-indented
> files. Over time, indentation invariably starts to mix, because developers
> with different indentation settings work on one file.
>
> Here are the current statistics for code in .phpt files:
>
> total: 15515
> prefer tabs: 4273 (27.5%)
> prefer spaces: 6307 (40.7%)
> draw: 77 (0.5%)
> no indentation: 4858 (31.3%)
>
> There are 1824 (11.8%) files that contain mixed tab and space indentation.
> The indentation was determined based on the first character of a line.
>
> I would like to propose that we establish a common standard by
> a) using space indentation for all future tests (as they currently form the
> majority), and
>

I usually use tabs for phpt as it's a bit simpler with my IDE that I use
for PHP core dev (QtCreator) and mostly the core exts that I work with had
tabs. That said I wouldn't be against making it the same and use spaces
everywhere if we also start using PSR-2 for tests - it's not just an
indentation that is a mess...


> b) reindenting existing test files to use space indentation.
>
>
+1 but it needs to be done in the lowest active branch otherwise it will
result in conflicts when changing existing tests (it is sometimes useful
for extending tests)...

Cheers

Jakub

--001a114e5e146e8475055cb3ded5--