Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100980
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.20 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CAF+90c_0RNfYDU25Os0azb2irnkV5N943KN76+WhO-iCxR+6Gg@mail.gmail.com>
Message-ID: <400665f7-3efa-8308-aff2-b721f9c7a601@gmx.de>
Date: Sat, 28 Oct 2017 14:42:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAF+90c_0RNfYDU25Os0azb2irnkV5N943KN76+WhO-iCxR+6Gg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Subject: Re: Consistent indentation for test files
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 28.10.2017 at 13:59, Nikita Popov wrote:

> Right now we do not have a consistent standard for the indentation of PHPT
> files. Some people create space-indented files, others create tab-indented
> files. Over time, indentation invariably starts to mix, because developers
> with different indentation settings work on one file.
> 
> Here are the current statistics for code in .phpt files:
> 
> total: 15515
> prefer tabs: 4273 (27.5%)
> prefer spaces: 6307 (40.7%)
> draw: 77 (0.5%)
> no indentation: 4858 (31.3%)
> 
> There are 1824 (11.8%) files that contain mixed tab and space indentation.
> The indentation was determined based on the first character of a line.

Thanks for bringing this up!

> I would like to propose that we establish a common standard by
> a) using space indentation for all future tests (as they currently form the
> majority), and
> b) reindenting existing test files to use space indentation.

+1

I'm rather baffled that <http://qa.php.net/write-test.php> doesn't
address this issue at all.

-- 
Christoph M. Becker