Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100978 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27406 invoked from network); 28 Oct 2017 11:59:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Oct 2017 11:59:57 -0000 Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.173 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 209.85.223.173 mail-io0-f173.google.com Received: from [209.85.223.173] ([209.85.223.173:45401] helo=mail-io0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8A/34-28573-B3174F95 for ; Sat, 28 Oct 2017 07:59:55 -0400 Received: by mail-io0-f173.google.com with SMTP id i38so17907310iod.2 for ; Sat, 28 Oct 2017 04:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=0f6NqFW5dKG7BUGmA7jkWLjMEkZfo5WN/pfIm4+fV10=; b=vf0EY54B3/md2FEdLKSkU6n+aL6b3+sICDz0JVUMV0el2/H/KAD1MxFBPez7cHl8bK DTSA7QdRueC2Xv2lBjggOEelTEM+QLb9yC9Hz/KRB3FxZ1T80mbBqUSJup+m95d2LPlf d3LYxFMnUe7y/kJ4ugzdqJ9X8O4cN/tFl/Ii0aY+tC41UJ8XlkNQRWWGiXaN3dqkqiJu 7UzfbVbg9kjhj5cQkOo++eP/yCQfej+hkXsIB8Ea87QonqNZWYpKoPQNy98Q0WEeJeTO QyAJ8g0HR9x51gMfYH0pxEiepm5vNOQCIEESjBPUF7mXETTxev0l96/q7l5L4izF/UMr r08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=0f6NqFW5dKG7BUGmA7jkWLjMEkZfo5WN/pfIm4+fV10=; b=ayZZZAbyk/tRGROZoo61MwSlH74aC+dNK7TZ/ThunURzRtUOQXmN0xH48lDuoc+xlq dZb1BA5fA+CLwxNKXrVDITPXvWxgbHRrE159emgKYUmS4H4f1aJxHuHMSuyPQSyxE0m2 CgkvXbS+HTekCWvgK8TLnWzwJuagKlv5MBoqzgt5J7X9v/JhFYvGVKrXVeIitYe3z1Ze 66lb7BkiFHwYKD2977dwvKem9rUN5yEh9QLpBZFsvKkAiHZV4/m/7Dy7Rl4Y+HbbBwL0 hMLyUjVO9KVf3jhVr10FdqL9EzHXH1jwUAUD18McG2cytqRgx13qrkA1lB71vFeut5uV mbuQ== X-Gm-Message-State: AMCzsaVa9g65GHabKyk/eJSomRllpBEGHVco2ozR/5ihDtyIYsGa3GzP 0Pvq9dJgx9f5wIcC8gpMw9jRI8DWMh8mP+Vb2IU3bw== X-Google-Smtp-Source: ABhQp+SFkQ+t8CsE4c5eUK2OoSak/srj6x/VoKbUApmU9Jyj2c9W+5aM3zgDjJ9Phz2iU1R1/tHk5umOMvpUSiHmWMg= X-Received: by 10.36.34.11 with SMTP id o11mr4417134ito.70.1509191992360; Sat, 28 Oct 2017 04:59:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.35.78 with HTTP; Sat, 28 Oct 2017 04:59:51 -0700 (PDT) Date: Sat, 28 Oct 2017 13:59:51 +0200 Message-ID: To: PHP internals Content-Type: multipart/alternative; boundary="001a113f77ba9a42e3055c9a2468" Subject: Consistent indentation for test files From: nikita.ppv@gmail.com (Nikita Popov) --001a113f77ba9a42e3055c9a2468 Content-Type: text/plain; charset="UTF-8" Hi internals, Right now we do not have a consistent standard for the indentation of PHPT files. Some people create space-indented files, others create tab-indented files. Over time, indentation invariably starts to mix, because developers with different indentation settings work on one file. Here are the current statistics for code in .phpt files: total: 15515 prefer tabs: 4273 (27.5%) prefer spaces: 6307 (40.7%) draw: 77 (0.5%) no indentation: 4858 (31.3%) There are 1824 (11.8%) files that contain mixed tab and space indentation. The indentation was determined based on the first character of a line. I would like to propose that we establish a common standard by a) using space indentation for all future tests (as they currently form the majority), and b) reindenting existing test files to use space indentation. Thanks, Nikita PS: Motivated by https://github.com/php/php-src/pull/2879. PRs regularly have WS issues. --001a113f77ba9a42e3055c9a2468--