Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100968 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57966 invoked from network); 27 Oct 2017 14:16:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Oct 2017 14:16:45 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.216.180 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.216.180 mail-qt0-f180.google.com Received: from [209.85.216.180] ([209.85.216.180:43519] helo=mail-qt0-f180.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 41/2F-28573-DCF33F95 for ; Fri, 27 Oct 2017 10:16:45 -0400 Received: by mail-qt0-f180.google.com with SMTP id j58so8603619qtj.0 for ; Fri, 27 Oct 2017 07:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=CkAN0E4hIfglQkzWb7IpFdB8naP2TXVe38bue+wCcgM=; b=cVCZAT+Aci1JPqdl0UTqvcMxXYXGVYkmN10jsbIh7eGzaI9i/NheMUGhEwZUOvPZ01 MBOXSTRYNlJRmT6spqrBNKBRNb9stONTfj1fOaD5pMoVcIgfApfC9J1GemgVH4A+WxCA ZdANlveaDRqCV8cuK1R4z3DW2WqCB5RzeDcZH62LN8HEcEj/y6TNPhgZoovArRnuMhej kE0tgLXsUTQBHfi1qiPYTpxVaRq7dEXx1r2JgWSxwUowjJ8+v9/ex34ppxAQVW0ibOOj k9mN4asPYJlwFOhzbLVt3t9EUP2jkSSz5oz0M4xWp3wUOe0vLZUycUBa5BljcArOmZOz iYow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=CkAN0E4hIfglQkzWb7IpFdB8naP2TXVe38bue+wCcgM=; b=HgN4YqEbMogTjld3vXsGJBmefikvfCrX7k1CYq/fJB33G+I5UVGAgXGPHJiMCoUGWu dI0tUAcmcwaPoHHM5kPcj7UnEMMsUg3TJmI/hJr0Q4wpIdP1fwkqz4+bCJqtKGvgv+k9 ACER1LBaqjzztiJLsPdtIloezlUHx/SDQXqtg+OEbrCse0h+v8T6GsSQj9hsPyzH3w3I Oz/USkGvxtQ/h+vJugXrI//BcBjyiWU09+OdEkIw5m1R8WD4+ncwCaaxZ7Er5opJLkNz 4QGxi/NEAiurDXfOWGjRjdZeWZW/61SwA8H+z2csw2JUK+ApxLuaUXo++vPq278R0MMp RrWA== X-Gm-Message-State: AMCzsaWQO6RKYPvB4kY50jTySIsFL8FntSQ7tx2WYfhMU/YSpXRs1o6A JRMeZOIFD+RfDVL+c5xCBeAfMoEQ+gyWOCFEgIzpHQ== X-Google-Smtp-Source: ABhQp+R4IaTpvXRISng3/evDJw5GhCUIfakHhg6pbi1jVKkMicyHw7nG54VR+4WJmrxeRu5U0/wsQiEd8Pp5cHbq0Ew= X-Received: by 10.200.50.193 with SMTP id a1mr1088233qtb.94.1509113803160; Fri, 27 Oct 2017 07:16:43 -0700 (PDT) MIME-Version: 1.0 Sender: php@golemon.com Received: by 10.12.156.1 with HTTP; Fri, 27 Oct 2017 07:16:42 -0700 (PDT) X-Originating-IP: [71.251.16.204] In-Reply-To: <20171027121225.2AAC95FB05@mx.zeyos.com> References: <20171027121225.2AAC95FB05@mx.zeyos.com> Date: Fri, 27 Oct 2017 10:16:42 -0400 X-Google-Sender-Auth: RS3MmHwWa7uRETLK7GYB1xOlktQ Message-ID: To: Benjamin Coutu Cc: PHP Internals , Dmitry Stogov , Nikita Popov Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Apply substr() optimization to array_slice() From: pollita@php.net (Sara Golemon) On Fri, Oct 27, 2017 at 8:12 AM, Benjamin Coutu wrote: > Now, array_slice() could be optimized similarly, but currently > (unless the resulting array is expected to be empty) we always > create a new array no matter if we actually have to. > Pushed, with an additional escape hatch for vector-like arrays (which are implicitly like preserve_keys). In the future though, please use the PR process. Thanks. -Sara