Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100964
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zeyos.com designates 88.99.153.70 as permitted sender)
Date: Fri, 27 Oct 2017 14:12:19 +0200
To: PHP Internals <internals@lists.php.net>
Cc: Dmitry Stogov <dmitry@zend.com>,  	Nikita Popov <nikita.ppv@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Message-ID: <20171027121225.2AAC95FB05@mx.zeyos.com>
Subject: Apply substr() optimization to array_slice()
From: ben.coutu@zeyos.com (Benjamin Coutu)

Hello everyone,=0A=0APlease consider these two statements:=0A=0Asubstr($str=
ing, 0, $length);=0Aarray_slice($array, 0, $length, true);=0A=0ACurrently, =
with substr(), if $offset is zero and $length is smaller or equal to the or=
iginal string length we just increase the reference count of the original s=
tring and return it via RETURN_STR_COPY.=0AIn that case we completely save =
the allocation of a new string.=0A=0ANow, array_slice() could be optimized =
similarly, but currently (unless the resulting array is expected to be empt=
y) we always create a new array no matter if we actually have to.=0AThe sam=
e mechanism as used with substr() could be applied to array_slice(), given =
that $offset is zero and of course only if $preserve_keys is true.=0A=0AA p=
atch would look like this:=0A=0Aif (length <=3D num_in && offset =3D=3D 0 &=
& preserve_keys) {=0A  /* Copy the original array */=0A  ZVAL_COPY(return_v=
alue, input);=0A  return;=0A}=0A=0AI'd appreciate if someone could commit t=
his. Thanks.=0A=0ACheers,=0A=0ABenjamin=0A=0A-- =0A=0ABejamin Coutu=0Aben.c=
outu@zeyos.com=0A=0AZeyOS, Inc.=0Ahttp://www.zeyos.com