Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100862
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.160 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAJd4=YaUjs+NaDvoNcS0kFu9_FuuVaSs-9YYxGB8v1OuxJzQig@mail.gmail.com>
References: <9a3f15dd-5dfc-144b-cc5f-66f689c33f53@php.net> <CAF+90c_hcR7VV1nvpH8f3e+H9oarUDG0B=ixvtf+ZkT9QL3UaA@mail.gmail.com>
 <CAJd4=YaUjs+NaDvoNcS0kFu9_FuuVaSs-9YYxGB8v1OuxJzQig@mail.gmail.com>
Date: Wed, 11 Oct 2017 13:48:31 +0200
Message-ID: <CANUQDCgmPib8SKmmqdr=0_CSeNSSbqu-Vje6xAJe0WWwGo3RgA@mail.gmail.com>
To: =?UTF-8?Q?Pedro_Magalh=C3=A3es?= <mail@pmmaga.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a1142ed64c151f3055b4400e5"
Subject: Re: [PHP-DEV] Strict type declarations not enforced for Reflection
 API invocation
From: me@kelunik.com (Niklas Keller)

--001a1142ed64c151f3055b4400e5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2017-10-11 11:03 GMT+02:00 Pedro Magalh=C3=A3es <mail@pmmaga.net>:

> On Tue, Oct 10, 2017 at 5:53 PM, Nikita Popov <nikita.ppv@gmail.com>
> wrote:
> >
> > The problem are not internal function calls, the problem are callbacks.
> In
> > fact, the proposed fix does not actually fix the problem you encountere=
d
> in
> > PHPUnit, as it is going to use the strictness mode at the reflection
> > call-site, not the strictness mode used by the file defining the data
> > provider.
> >
>
> For those that didn't have a look at the PR, my goal was to try to ensure
> that if we are looking for which strictness to use, we should look at the
> place of the closest "user" call instead of the function (user or interna=
l)
> that called the current one. The reason for this problem lies in the fact
> that `ZEND_ARG_USES_STRICT_TYPES()` will simply look at the caller
> regardless of what it is. Although this is enough to allow calling
> functions that were defined as non-strict in a strict manner, it does cau=
se
> this kind of shortcomings with callbacks.
>
>
> > I believe that the proper way to fix this is to handle dynamic function
> > invocations differently from direct invocations. Direct invocations
> should
> > use the strictness level of the call-site, while dynamic invocations
> should
> > use the strictness level of the declaration-site.
>

I'm not sure about that. That might be reasonable for closures, but not for
other dynamic invocations.


> I agree that this should be about dynamic vs direct instead of user vs
> internal but IMHO, making the strictness vary from call-site to
> declaration-site depending on that may be a bit too confusing. Would it b=
e
> possible/reasonable to try to find the place where the dynamic call was
> started? (i.e. the dataProvider, the mapped function for a userland
> array_map, etc...)
>

I don't think that's reasonably possible. Think about some event emitter
like that:

```
class EventEmitter {
    private array $callbacks =3D [];

    public function on(string $eventName, callable $callback): void {
        $this->callbacks[$eventName][] =3D $callback;
    }

    public function emit(string $eventName, $value): void {
        foreach ($this->callbacks[$eventName] ?? [] as $callback) {
            $callback($value);
        }
    }
}
```

Where is a dynamic call to a registered callback started? Depending on the
strictness level of the caller of `emit()`? What if that `emit()` is called
from another file with another strictness level?

Regards, Niklas

--001a1142ed64c151f3055b4400e5--