Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100828
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.175 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <1507207809.1967.31.camel@schlueters.de>
References: <CAESVnVrVZc85AUwgDXaZEZdjvDRz_zs55Oh8t4_WjdgTYXKxyg@mail.gmail.com>
 <1507207809.1967.31.camel@schlueters.de>
Date: Thu, 5 Oct 2017 11:28:23 -0400
Message-ID: <CAESVnVpgkqu4xnWCCaW0noTbNZaeN6KS+mORQ=0JT2JbLi8hsA@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, 
	Kalle Sommer Nielsen <kalle@php.net>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Expose gmp_ce and friends
From: pollita@php.net (Sara Golemon)

On Thu, Oct 5, 2017 at 8:50 AM, Johannes Schl=C3=BCter
<johannes@schlueters.de> wrote:
> I would prefer not exporting the php_gmp.h, but a gmp.h (or similar)
> and let php_gmp.h there for main/builtin_functions.c only. If a
> consumer wants access to the module_entry they can query EG(modules)
> and other declarations in there should be "private".
>
Yeah, I shouldn't be lazy. I should do things right.

On Wed, Oct 4, 2017 at 5:32 PM, Kalle Sommer Nielsen <kalle@php.net> wrote:
 > +1, only note I have is that with the change to config.m4, a relevant
> one should maybe also follow for phpize on Windows for config.w32
>
Ugh, windows... is that still a thing?