Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100825 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82662 invoked from network); 5 Oct 2017 12:50:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Oct 2017 12:50:19 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 84.19.169.162 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 84.19.169.162 mail.experimentalworks.net Received: from [84.19.169.162] ([84.19.169.162:59268] helo=mail.experimentalworks.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 03/00-16800-88A26D95 for ; Thu, 05 Oct 2017 08:50:17 -0400 Received: from kuechenschabe.fritz.box (ppp-46-244-187-162.dynamic.mnet-online.de [46.244.187.162]) by mail.experimentalworks.net (Postfix) with ESMTPSA id 2C522664D6; Thu, 5 Oct 2017 14:50:13 +0200 (CEST) Message-ID: <1507207809.1967.31.camel@schlueters.de> To: Sara Golemon , Stanislav Malyshev , PHP internals Date: Thu, 05 Oct 2017 14:50:09 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Expose gmp_ce and friends From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) On Mo, 2017-10-02 at 17:33 -0400, Sara Golemon wrote: > Stas specifically, but also others: > > Any objections if I apply > https://github.com/php/php-src/compare/master...sgolemon:gmp.export > to > make consuming GMP objects from third-party extensions easier? > > -Sara I would prefer not exporting the php_gmp.h, but a gmp.h (or similar) and let php_gmp.h there for main/builtin_functions.c only. If a consumer wants access to the module_entry they can query EG(modules) and other declarations in there should be "private". johannes