Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100819
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain bohwaz.net designates 5.135.163.151 as permitted sender)
To: Dan Ackroyd <danack@basereality.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 04 Oct 2017 11:41:17 +1300
Cc: internals@lists.php.net
In-Reply-To: <CA+kxMuRoujf=Ma89w+8Oz_d8NY79kp=dwchw2K8=KYWyC0uMVg@mail.gmail.com>
References: <25903b1e0fc5a726e44b1e3a5ab4aec4@bohwaz.net>
 <0607d622-caa9-ae1d-33db-1958a0ff0500@gmx.de>
 <20171001185540.5e572e58@platypus>
 <dc5f105093c2613e5cde97f9eb4833ce@bohwaz.net>
 <ee13647a-d723-3dcb-24fc-5906ffb58a8c@lsces.co.uk>
 <209262d743236c86c8d66972922fba13@bohwaz.net>
 <CA+kxMuRoujf=Ma89w+8Oz_d8NY79kp=dwchw2K8=KYWyC0uMVg@mail.gmail.com>
Message-ID: <7568ec6becf883d3abbb78d55ad7a87c@bohwaz.net>
User-Agent: Roundcube Webmail/1.1.5
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Implement SQLite "openBlob"  feature in PDO
From: php@bohwaz.net (BohwaZ/PHP)

> Taking it to a better solution is that the method sqliteCreateFunction
> shouldn't exist on the PDO class, but instead on a PDOSqlite that
> extends PDO.
> 
> class PDOSqlite extends PDO {
>      public function createFunction(...) {...}
> }
> 
> class PDO {
>     public static function connect(string $dsn [, string $username [,
> string $password [, array $options ]]]) {
>        // if connecting to SQLite DB {
>            return new PDOSqlite(...);
>        }
>     }
> }
> 
> This might be a mistake in how it was implemented originally. Looking
> back it seems that it was implemented before we had the RFC
> process....and is exactly the type of 'sub-optimal' implementation the
> RFC process is meant to prevent.

Yes I do agree that the method overloading of PDO by drivers is not the 
best to say the least.

If you feel like rewriting a large part of PDO feel free :) but I don't 
have time for that, and it's not the subject of this RFC :)