Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100814
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <dc5f105093c2613e5cde97f9eb4833ce@bohwaz.net>
References: <25903b1e0fc5a726e44b1e3a5ab4aec4@bohwaz.net> <0607d622-caa9-ae1d-33db-1958a0ff0500@gmx.de>
 <20171001185540.5e572e58@platypus> <dc5f105093c2613e5cde97f9eb4833ce@bohwaz.net>
Date: Tue, 3 Oct 2017 14:22:17 +0000
Message-ID: <CADxrgCMmPw84Kj9nYAs6LNcXDFoupFR2F_wog2--E02Bcra3gw@mail.gmail.com>
To: "BohwaZ/PHP" <php@bohwaz.net>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c035748f585c3055aa5377b"
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Implement SQLite "openBlob"
 feature in PDO
From: adambaratz@php.net (Adam Baratz)

--94eb2c035748f585c3055aa5377b
Content-Type: text/plain; charset="UTF-8"

>
> PDO already has support for large objects (LOBs)[1].  I don't know if
>>> and how these are supported by the pdo_sqlite driver, but wouldn't it
>>> make sense to use the existing API instead of introducing a new
>>> method?
>>>
>>> [1] <http://www.php.net/manual/en/pdo.lobs.php>
>>>
>>>
>> Very interesting indeed, didn't know about that feature, I was
>> expecting the creation of a new method was the only way, as this was
>> the way PGSQL was doing it.
>>
>> There's even a bug report about it:
>> https://bugs.php.net/bug.php?id=57691
>>
>> I will look into that next week and see if it can fit and replace my RFC
>> then.
>>
>
>
> OK, I took some time to look into that feature and the fact is that it
> doesn't work at all currently with SQLite, it is not returning a resource
> handle but a string, and it is consuming a large amount of memory as it is
> just dumping the LOB in memory. The code seems to be there to handle it
> though so I don't know what's going on, if the person who implemented that
> could come forward and tell me more about the implementation.


I believe that's how PDO::PARAM_LOB is intended to work (based on my
reading of the docs and implementations for other drivers). It seems like
more of a convenience than anything, though maybe someone had more ideas
for how it should work across drivers and never got to follow through on it.

The RFC is agreeable to me because it follows the existing ext/sqlite3 API
and uses the existing pattern in pdo_sqlite for integrating driver-specific
APIs. I'd love it if PDO had better BLOB/LOB types and if we had a better
pattern for driver-specific APIs, but I'm comfortable lumping those goals
under "future scope." Getting parity with ext/sqlite3 will make pdo_sqlite
more usable, which will help grow its community, and the number of people
who are able to contribute to these bigger projects. Deprecating the
current set of driver-specific APIs in the future, if we have functional
equivalents, isn't an impossible project.

Thanks,
Adam

--94eb2c035748f585c3055aa5377b--