Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100813
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.192.173 cause and error)
MIME-Version: 1.0
In-Reply-To: <209262d743236c86c8d66972922fba13@bohwaz.net>
References: <25903b1e0fc5a726e44b1e3a5ab4aec4@bohwaz.net> <0607d622-caa9-ae1d-33db-1958a0ff0500@gmx.de>
 <20171001185540.5e572e58@platypus> <dc5f105093c2613e5cde97f9eb4833ce@bohwaz.net>
 <ee13647a-d723-3dcb-24fc-5906ffb58a8c@lsces.co.uk> <209262d743236c86c8d66972922fba13@bohwaz.net>
Date: Tue, 3 Oct 2017 14:59:01 +0100
Message-ID: <CA+kxMuRoujf=Ma89w+8Oz_d8NY79kp=dwchw2K8=KYWyC0uMVg@mail.gmail.com>
To: "BohwaZ/PHP" <php@bohwaz.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Implement SQLite "openBlob"
 feature in PDO
From: danack@basereality.com (Dan Ackroyd)

On 2 October 2017 at 22:48, BohwaZ/PHP <php@bohwaz.net> wrote:
>
> If you follow your logic, then PDO::sqliteCreateFunction shouldn't exist,
> and this would make the PDO sqlite driver pretty much useless as SQLite is
> missing a number of important functions.


That's taking it to the illogical conclusion.

Taking it to a better solution is that the method sqliteCreateFunction
shouldn't exist on the PDO class, but instead on a PDOSqlite that
extends PDO.

class PDOSqlite extends PDO {
     public function createFunction(...) {...}
}

class PDO {
    public static function connect(string $dsn [, string $username [,
string $password [, array $options ]]]) {
       // if connecting to SQLite DB {
           return new PDOSqlite(...);
       }
    }
}

This might be a mistake in how it was implemented originally. Looking
back it seems that it was implemented before we had the RFC
process....and is exactly the type of 'sub-optimal' implementation the
RFC process is meant to prevent.

> This is why I am pushing for PDO to be feature-full, so that you have the
> choice to use PDO and not have to implement your own abstraction layer just
> because you need one specific feature in one single case :)
>

That's a great aim!

But rather thank just hack in new features building on sub-optimal
ways of doing things, I think it would be better to create a plan to
clean up the way that connection specific methods are available, with
something along the lines of that which I mentioned above.

cheers
Dan
Ack