Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100812
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 74.125.83.46 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAOV5rgZ57dezubTW_GVDHiyO-y3Z+n2=iF+PDTMe14RrK3VS_g@mail.gmail.com>
References: <CAOV5rgZ57dezubTW_GVDHiyO-y3Z+n2=iF+PDTMe14RrK3VS_g@mail.gmail.com>
Date: Tue, 3 Oct 2017 14:44:18 +0100
Message-ID: <CA+kxMuT7E3s5-bmLUasdXSB2MePPP9JNft_uXV-ViJK-QP+_1g@mail.gmail.com>
To: nyamsprod the funky webmaster <nyamsprod@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Making stream functions accepting SplFileObject as
 valid parameter
From: danack@basereality.com (Dan Ackroyd)

On 29 September 2017 at 07:46, nyamsprod the funky webmaster
<nyamsprod@gmail.com> wrote:
> Hi internals,
>
> I've been following the resolution of this bug:
>
> https://bugs.php.net/bug.php?id=44392
>
> and it seems that there is no safe way to expose the internal
> `SplFileObject` filepointer.


Hi nyamsprod the funky webmaster,

It seems that people are scared to comment on a streams related question...

I'm not sure that making stream_* functions accept SplFileObject's
would be an appropriate way to solve this problem; it's just too much
of a hack.

However, although it's not safe to expose the underlying file handle
used by SplFileObject, I think it _might_ be safe to allow the
SplFileObject to return a stream that represents the file, but with
the necessary php_stream_ops that aren't safe to use replaced with NOP
operations, similar to how it is done in the pgsql extension:
https://github.com/php/php-src/blob/879126a2cedef5b6e1c1f701ade17ca3da9a39ec/ext/pgsql/pgsql.c#L5406-L5409

static int php_pgsql_fd_close(php_stream *stream, int close_handle) /* {{{ */
{
    return EOF;
}

To expose the internal stream to userland.

I'd really like to hear from anyone who knows about streams internals
to know if that's a viable approach.

cheers
Dan
Ack