Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100780
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <ee76dfe0-8bda-086a-33cd-d0f8c33aa071@lsces.co.uk>
References: <25903b1e0fc5a726e44b1e3a5ab4aec4@bohwaz.net> <CA+kxMuQ0p9qwCkxaUFQuR4C_JrPb1RtAguY3su3TvPsiUxOGEw@mail.gmail.com>
 <ee76dfe0-8bda-086a-33cd-d0f8c33aa071@lsces.co.uk>
Date: Wed, 27 Sep 2017 11:04:09 +0200
Message-ID: <CADyq6sJJBY_sfOiH+Zh-sPZbhkYDWegerkYBrBDP235n62DY9A@mail.gmail.com>
To: Lester Caine <lester@lsces.co.uk>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a114246b45cef0c055a2814dc"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature
 in PDO
From: ocramius@gmail.com (Marco Pivetta)

--001a114246b45cef0c055a2814dc
Content-Type: text/plain; charset="UTF-8"

On Wed, Sep 27, 2017 at 11:00 AM, Lester Caine <lester@lsces.co.uk> wrote:

> On 27/09/17 09:47, Dan Ackroyd wrote:
> >> https://wiki.php.net/rfc/implement_sqlite_openblob_in_pdo
> >
> > Couple of questions:
> >
> >> $stream = $pdo->sqliteOpenBlob('test', 'data', 1);
> > I tried reading the code but failed; what happens when this is called
> > on a PDO connection that isn't to an SQLite database? Also, there
> > should probably be tests around that behaviour.
>
> The bigger question is - Should database specific extensions to PDO be
> allowed at all? The WHOLE base of PDO was that it would allow easy data
> management between DIFFERENT databases. This should be implemented in a
> way that mirrors blobs generically otherwise the generic database driver
> should be used since a switch to another PDO driver will fail. This
> should apply to any targeted extension to PDO, so anything that breaks
> the generic base data needs tidying up.
>

First time I agree with Lester here, so please take note :-P

Unless the type of the connection is PDOSQLiteConnection, this specific
patch adds methods that are not interfaced, and need to be checked for
existence every time. This is error-prone and just an annoyance that will
likely need abstraction once it reaches "real world" (layers that isolate
apps from PDO's inherent radioactivity).

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a114246b45cef0c055a2814dc--